From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C24F4C43381 for ; Mon, 18 Feb 2019 07:52:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91CFB217F5 for ; Mon, 18 Feb 2019 07:52:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728923AbfBRHw3 (ORCPT ); Mon, 18 Feb 2019 02:52:29 -0500 Received: from mx2.suse.de ([195.135.220.15]:42516 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725881AbfBRHw3 (ORCPT ); Mon, 18 Feb 2019 02:52:29 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 49A2DAFBE; Mon, 18 Feb 2019 07:52:27 +0000 (UTC) Date: Mon, 18 Feb 2019 08:52:26 +0100 Message-ID: From: Takashi Iwai To: "Daniel Baluta" Cc: "kuninori.morimoto.gx@renesas.com" , "alsa-devel@alsa-project.org" , "lgirdwood@gmail.com" , "vicencb@gmail.com" , "broonie@kernel.org" , "gregkh@linuxfoundation.org" , "dl-linux-imx" , "S.j. Wang" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ASoC: simple-card: Fix refcount underflow In-Reply-To: References: <20190216100927.10017-1-daniel.baluta@nxp.com> <87pnrp52jl.wl-kuninori.morimoto.gx@renesas.com> <87lg2d51lv.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Feb 2019 08:06:19 +0100, Daniel Baluta wrote: > > On Mon, 2019-02-18 at 10:37 +0900, Kuninori Morimoto wrote: > > Hi Daniel, Mark, again > > > > > > of_get_child_by_name() takes a reference we'll need to drop > > > > later so when we substitute in top we need to take a reference > > > > as well as just assigning. > > > > > > > > Without this patch we hit the following error: > > > > > > > > [ 1.246852] OF: ERROR: Bad of_node_put() on /sound-wm8524 > > > > [ 1.262261] Hardware name: NXP i.MX8MQ EVK (DT) > > > > [ 1.266807] Workqueue: events deferred_probe_work_func > > > > [ 1.271950] Call trace: > > > > [ 1.274406] dump_backtrace+0x0/0x158 > > > > [ 1.278074] show_stack+0x14/0x20 > > > > [ 1.281396] dump_stack+0xa8/0xcc > > > > [ 1.284717] of_node_release+0xb0/0xc8 > > > > [ 1.288474] kobject_put+0x74/0xf0 > > > > [ 1.291879] of_node_put+0x14/0x28 > > > > [ 1.295286] __of_get_next_child+0x44/0x70 > > > > [ 1.299387] of_get_next_child+0x3c/0x60 > > > > [ 1.303315] simple_for_each_link+0x1dc/0x230 > > > > [ 1.307676] simple_probe+0x80/0x540 > > > > [ 1.311256] platform_drv_probe+0x50/0xa0 > > > > > > > > This patch is based on an earlier version posted by Kuninori > > > > Morimoto > > > > and commit message includes explanations from Mark Brown. > > > > > > > > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fpatch%2F10814255%2F&data=02%7C01%7Cdaniel.baluta%40nxp.com%7Ced1b7adc66a546c1bb4608d69541aaf8%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636860506617983174&sdata=hTsurDLdtLAtTw0a5v%2FrSsleSawAP2yiVPl87%2BHCzTI%3D&reserved=0 > > > > > > > > Reported-by: Vicente Bergas > > > > Signed-off-by: Daniel Baluta > > > > --- > > > > > > I'm not sure which one is correct in this case > > > > > > Signed-off-by: Kuninori Morimoto > > > > > > or > > > > > > Acked-by: Kuninori Morimoto > > > > And we want to add > > > > Fixes: commit da215354eb55c ("ASoC: simple-card: merge simple-scu- > > card") > > > > Thanks! I thought about adding this but the current patch will not > cleanly apply because of: > > 2d01a84605a55c ("ASoC: simple-card: reduce naming prefix") Yeah, it's a bit tricky because of the code change at this time. At best, send two patches, once for 5.0 and once for 5.1, and let Mark apply both of them and do the empty merge from 5.0 to 5.1, or let him resolve the merge conflict by applying manually the 5.1 patch. thanks, Takashi