From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753338AbdHTUgA (ORCPT <rfc822;w@1wt.eu>);
        Sun, 20 Aug 2017 16:36:00 -0400
Received: from mx2.suse.de ([195.135.220.15]:43691 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1753191AbdHTUf6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 20 Aug 2017 16:35:58 -0400
Date: Sun, 20 Aug 2017 22:35:55 +0200
Message-ID: <s5hpobqrn84.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>, alsa-devel@alsa-project.org,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        kbuild-all@01.org
Subject: Re: [PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings
In-Reply-To: <20170820162841.GA1176@dtor-ws>
References: <alpine.DEB.2.20.1708201118140.3678@hadrien>
        <20170820162841.GA1176@dtor-ws>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 20 Aug 2017 18:28:41 +0200,
Dmitry Torokhov wrote:
> 
> On Sun, Aug 20, 2017 at 11:19:38AM +0200, Julia Lawall wrote:
> > No need to set .owner here. The core will do it.
> > 
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> > 
> > Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power button")
> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
> > 
> >  dc_ti_pwrbtn.c |    1 -
> 
> Hm, this driver is neither in my tree nor in next; where is it coming
> from?

It's only in my tree for testing, but kbuild bot takes all branches
unconditionally, so...

In anyway, I hope I can submit sooner or later :)


Takashi


> 
> >  1 file changed, 1 deletion(-)
> > 
> > --- a/drivers/input/keyboard/dc_ti_pwrbtn.c
> > +++ b/drivers/input/keyboard/dc_ti_pwrbtn.c
> > @@ -75,7 +75,6 @@ static int dc_ti_pwrbtn_probe(struct pla
> >  static struct platform_driver dc_ti_pwrbtn_driver = {
> >  	.driver = {
> >  		.name = DRIVER_NAME,
> > -		.owner = THIS_MODULE,
> >  	},
> >  	.probe	= dc_ti_pwrbtn_probe,
> >  };
> 
> -- 
> Dmitry
>