From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753527AbdGCJNJ (ORCPT <rfc822;w@1wt.eu>);
        Mon, 3 Jul 2017 05:13:09 -0400
Received: from mx2.suse.de ([195.135.220.15]:38806 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1752942AbdGCJNH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 Jul 2017 05:13:07 -0400
Date: Mon, 03 Jul 2017 11:13:04 +0200
Message-ID: <s5hpodhc28v.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Robert Jarzmik" <robert.jarzmik@free.fr>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
        "Haojian Zhuang" <haojian.zhuang@gmail.com>,
        "Liam Girdwood" <lgirdwood@gmail.com>,
        "Mark Brown" <broonie@kernel.org>, "Lee Jones" <lee.jones@linaro.org>,
        "Lars-Peter Clausen" <lars@metafoo.de>,
        "Charles Keepax" <ckeepax@opensource.wolfsonmicro.com>,
        "Jaroslav Kysela" <perex@perex.cz>, "Daniel Mack" <daniel@zonque.org>,
        <alsa-devel@alsa-project.org>, <linux-arm-kernel@lists.infradead.org>,
        <patches@opensource.wolfsonmicro.com>, <linux-input@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 02/12] ALSA: ac97: add an ac97 bus
In-Reply-To: <20170630194408.24978-3-robert.jarzmik@free.fr>
References: <20170630194408.24978-1-robert.jarzmik@free.fr>
        <20170630194408.24978-3-robert.jarzmik@free.fr>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 30 Jun 2017 21:43:58 +0200,
Robert Jarzmik wrote:
> +static struct bus_type ac97_bus_type = {
> +	.name		= "ac97",

Name-conflict with the old ac97 bus?

> +	.dev_groups	= ac97_dev_groups,
> +	.match		= ac97_bus_match,
> +	.pm		= &ac97_pm,
> +	.probe		= ac97_bus_probe,
> +	.remove		= ac97_bus_remove,
> +};
> +
> +static int __init ac97_bus_init(void)
> +{
> +	return bus_register(&ac97_bus_type);
> +}
> +subsys_initcall(ac97_bus_init);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Robert Jarzmik <robert.jarzmik@free.fr>");

No bus_unregister() at exit?


thanks,

Takashi