From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754978AbcB2MY3 (ORCPT ); Mon, 29 Feb 2016 07:24:29 -0500 Received: from mx2.suse.de ([195.135.220.15]:51277 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753638AbcB2MY0 (ORCPT ); Mon, 29 Feb 2016 07:24:26 -0500 Date: Mon, 29 Feb 2016 13:24:24 +0100 Message-ID: From: Takashi Iwai To: "Sudip Mukherjee" Cc: "Jaroslav Kysela" , , Subject: Re: [PATCH] ALSA: mts64: fix NULL pointer dereference In-Reply-To: <1456748010-17038-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1456748010-17038-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 Feb 2016 13:13:30 +0100, Sudip Mukherjee wrote: > > While registering pardev, the irq_func was also registered. As a > result when we tried to probe for the card, an interrupt was generated > and in the ISR we tried to dereference private_data. But private_data > is still NULL as we have not yet done snd_mts64_create(). Lets probe > for the card after mts64 is created. > > Reported-by: Fengguang Wu > Fixes: 94a573500d48 ("ALSA: mts64: use new parport device model") > Signed-off-by: Sudip Mukherjee Applied, thanks. Takashi > --- > sound/drivers/mts64.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/sound/drivers/mts64.c b/sound/drivers/mts64.c > index c76bd87..fd4d18d 100644 > --- a/sound/drivers/mts64.c > +++ b/sound/drivers/mts64.c > @@ -964,11 +964,6 @@ static int snd_mts64_probe(struct platform_device *pdev) > err = -EIO; > goto free_pardev; > } > - err = mts64_probe(p); > - if (err) { > - err = -EIO; > - goto release_pardev; > - } > > if ((err = snd_mts64_create(card, pardev, &mts)) < 0) { > snd_printd("Cannot create main component\n"); > @@ -976,6 +971,12 @@ static int snd_mts64_probe(struct platform_device *pdev) > } > card->private_data = mts; > card->private_free = snd_mts64_card_private_free; > + > + err = mts64_probe(p); > + if (err) { > + err = -EIO; > + goto __err; > + } > > if ((err = snd_mts64_rawmidi_create(card)) < 0) { > snd_printd("Creating Rawmidi component failed\n"); > -- > 1.9.1 > >