From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932858AbaJUN5E (ORCPT ); Tue, 21 Oct 2014 09:57:04 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50617 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932551AbaJUN5B (ORCPT ); Tue, 21 Oct 2014 09:57:01 -0400 Date: Tue, 21 Oct 2014 15:56:59 +0200 Message-ID: From: Takashi Iwai To: Sudip Mukherjee Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: ctxfi: remove unused variable In-Reply-To: <1413889127-18754-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1413889127-18754-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 21 Oct 2014 16:28:47 +0530, Sudip Mukherjee wrote: > > As of now the pointer to struct dai is not being used anywhere in the > function. So it is safe to remove the variable. > If we are ever doing anything with the container_of(daio, struct dai, daio), > then at that time we can again add the variable. > > Signed-off-by: Sudip Mukherjee Applied, thanks. Takashi > --- > sound/pci/ctxfi/ctatc.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/sound/pci/ctxfi/ctatc.c b/sound/pci/ctxfi/ctatc.c > index 4546590..632e843 100644 > --- a/sound/pci/ctxfi/ctatc.c > +++ b/sound/pci/ctxfi/ctatc.c > @@ -1145,7 +1145,6 @@ static int atc_release_resources(struct ct_atc *atc) > int i; > struct daio_mgr *daio_mgr = NULL; > struct dao *dao = NULL; > - struct dai *dai = NULL; > struct daio *daio = NULL; > struct sum_mgr *sum_mgr = NULL; > struct src_mgr *src_mgr = NULL; > @@ -1172,9 +1171,6 @@ static int atc_release_resources(struct ct_atc *atc) > dao = container_of(daio, struct dao, daio); > dao->ops->clear_left_input(dao); > dao->ops->clear_right_input(dao); > - } else { > - dai = container_of(daio, struct dai, daio); > - /* some thing to do for dai ... */ > } > daio_mgr->put_daio(daio_mgr, daio); > } > -- > 1.8.1.2 >