From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933057AbaFLJ7Y (ORCPT ); Thu, 12 Jun 2014 05:59:24 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50424 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932673AbaFLJ7W (ORCPT ); Thu, 12 Jun 2014 05:59:22 -0400 Date: Thu, 12 Jun 2014 11:59:20 +0200 Message-ID: From: Takashi Iwai To: Vinod Koul Cc: "Wang, Xiaoming" , jeeja.kp@intel.com, dhowells@redhat.com, arnd@arndb.de, tglx@linutronix.de, mtk.manpages@gmail.com, paulmck@linux.vnet.ibm.com, davej@redhat.com, linux-kernel@vger.kernel.org, dongxing.zhang@intel.com Subject: Re: [PATCH] ALSA: compress: Cancel the optimization of compiler and fix the size of struct for all platform. In-Reply-To: <20140612092513.GA22053@intel.com> References: <1402613227.8326.13.camel@wxm-ubuntu> <20140612092513.GA22053@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 12 Jun 2014 14:55:13 +0530, Vinod Koul wrote: > > On Thu, Jun 12, 2014 at 06:47:07PM -0400, Wang, Xiaoming wrote: > > Cancel the optimization of compiler for struct snd_compr_avail > > which size will be 0x1c in 32bit kernel while 0x20 in 64bit > > kernel under the optimizer. That will make compaction between > > 32bit and 64bit. So add packed to fix the size of struct > > snd_compr_avail to 0x1c for all platform. > > > > Signed-off-by: Zhang Dongxing > > Signed-off-by: xiaoming wang > > Acked-by: Vinod Koul > > Takashi, can we cc stable on this, would help fixing in older kernels too Yes, applied with Cc to stable now. thanks, Takashi > > Thanks > -- > ~Vinod > > --- > > include/uapi/sound/compress_offload.h | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/include/uapi/sound/compress_offload.h b/include/uapi/sound/compress_offload.h > > index 5759810..21eed48 100644 > > --- a/include/uapi/sound/compress_offload.h > > +++ b/include/uapi/sound/compress_offload.h > > @@ -80,7 +80,7 @@ struct snd_compr_tstamp { > > struct snd_compr_avail { > > __u64 avail; > > struct snd_compr_tstamp tstamp; > > -}; > > +} __attribute__((packed)); > > > > enum snd_compr_direction { > > SND_COMPRESS_PLAYBACK = 0, > > -- > > 1.7.1 > > > > -- >