From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753926Ab1HGPhr (ORCPT ); Sun, 7 Aug 2011 11:37:47 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53672 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753260Ab1HGPhp (ORCPT ); Sun, 7 Aug 2011 11:37:45 -0400 Date: Sun, 07 Aug 2011 17:37:43 +0200 Message-ID: From: Takashi Iwai To: Randy Dunlap Cc: Stephen Rothwell , linux-media@vger.kernel.org, Mauro Carvalho Chehab , linux-next@vger.kernel.org, LKML , Ondrej Zary Subject: Re: linux-next: Tree for Aug 5 (media/radio/radio-sf16fmr2) In-Reply-To: <20110806095004.017f6771.rdunlap@xenotime.net> References: <20110805143103.f9388ca143560d73caac60c1@canb.auug.org.au> <20110805165611.d2feaf32.rdunlap@xenotime.net> <20110806095004.017f6771.rdunlap@xenotime.net> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sat, 6 Aug 2011 09:50:04 -0700, Randy Dunlap wrote: > > On Sat, 06 Aug 2011 10:33:39 +0200 Takashi Iwai wrote: > > > At Fri, 5 Aug 2011 16:56:11 -0700, > > Randy Dunlap wrote: > > > > > > On Fri, 5 Aug 2011 14:31:03 +1000 Stephen Rothwell wrote: > > > > > > > Hi all, > > > > > > > > [The kernel.org mirroring is running slowly today] > > > > > > Is media/radio/radio-sf16fmr2 an ISA driver or a PCI driver? > > > ugh. Or is it an I2C driver? > > > > > > > > > linux-next fails with (this is not a new failure): > > > > > > ERROR: "snd_tea575x_init" [drivers/media/radio/radio-sf16fmr2.ko] undefined! > > > ERROR: "snd_tea575x_exit" [drivers/media/radio/radio-sf16fmr2.ko] undefined! > > > > > > The Kconfig entry for RADIO_SF16FMR2 is: > > > > > > config RADIO_SF16FMR2 > > > tristate "SF16FMR2 Radio" > > > depends on ISA && VIDEO_V4L2 && SND > > > > > > and the Kconfig entry for SND_TEA575X is (not user visible): > > > > > > config SND_TEA575X > > > tristate > > > depends on SND_FM801_TEA575X_BOOL || SND_ES1968_RADIO || RADIO_SF16FMR2 > > > default SND_FM801 || SND_ES1968 || RADIO_SF16FMR2 > > > > > > This latter entry is in sound/pci/Kconfig and is under: > > > if SND_PCI > > > so it depends on PCI and SND_PCI. > > > > > > This build fails when CONFIG_PCI is not enabled. > > > > tea575x-tuner is an i2c component (not meaning Linux i2c-subsystem), > > thus should be independent from the board bus type. > > Does a patch like below work? > > > > Yes, it does. Thanks. > > Reported-by: Randy Dunlap > Acked-by: Randy Dunlap Thanks, now fixed in sound git tree. Takashi > > > > > > thanks, > > > > Takashi > > > > --- > > diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig > > index 50abf5b..8816804 100644 > > --- a/sound/pci/Kconfig > > +++ b/sound/pci/Kconfig > > @@ -1,5 +1,10 @@ > > # ALSA PCI drivers > > > > +config SND_TEA575X > > + tristate > > + depends on SND_FM801_TEA575X_BOOL || SND_ES1968_RADIO || RADIO_SF16FMR2 > > + default SND_FM801 || SND_ES1968 || RADIO_SF16FMR2 > > + > > menuconfig SND_PCI > > bool "PCI sound devices" > > depends on PCI > > @@ -563,11 +568,6 @@ config SND_FM801_TEA575X_BOOL > > FM801 chip with a TEA5757 tuner (MediaForte SF256-PCS, SF256-PCP and > > SF64-PCR) into the snd-fm801 driver. > > > > -config SND_TEA575X > > - tristate > > - depends on SND_FM801_TEA575X_BOOL || SND_ES1968_RADIO || RADIO_SF16FMR2 > > - default SND_FM801 || SND_ES1968 || RADIO_SF16FMR2 > > - > > source "sound/pci/hda/Kconfig" > > > > config SND_HDSP > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-next" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > --- > ~Randy > *** Remember to use Documentation/SubmitChecklist when testing your code *** >