mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Madis Janson <madis@cyber.ee>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Enable Realtek ALC269 codec input layer beep
Date: Thu, 19 May 2011 18:33:47 +0200	[thread overview]
Message-ID: <s5hpqnetztg.wl%tiwai@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1105191925570.2046@paabel.itsise>

At Thu, 19 May 2011 19:31:36 +0300 (EEST),
Madis Janson wrote:
> 
> 
> On Thu, 19 May 2011, Takashi Iwai wrote:
> 
> > The change look good, but could you give your sign-off?
> > See Documentation/SubmittingPatches section 12 "Sign your work" for
> > details.
> >
> > Also, at the next time, please try to send the patch to the
> > corresponding subsystem maintainers.  scripts/get_maintainer.pl is
> > your friend.
> 
> Ok. Would this sign-off suffice? :)

Yep.  Applied now.  Thanks.


Takashi

> ---
> 
> This fixes the input layer beep not working on some EeePC 1000 models by
> adding the subsystem id into whitelist. Otherwise the corresponding ALSA
> mixer is not enabled and stays muted, resulting in no console beep.
> 
> Signed-off-by: Madis Janson <madis@cyber.ee>
> 
> diff -u linux-2.6.39/sound/pci/hda/patch_realtek.c lohe-2.6.39/sound/pci/hda/patch_realtek.c
> --- linux-2.6.39/sound/pci/hda/patch_realtek.c	2011-05-19 07:06:34.000000000 +0300
> +++ lohe-2.6.39/sound/pci/hda/patch_realtek.c	2011-05-19 11:58:28.415669828 +0300
> @@ -5646,6 +5646,7 @@
>   	SND_PCI_QUIRK(0x1043, 0x829f, "ASUS", 1),
>   	SND_PCI_QUIRK(0x1043, 0x83ce, "EeePC", 1),
>   	SND_PCI_QUIRK(0x1043, 0x831a, "EeePC", 1),
> +	SND_PCI_QUIRK(0x1043, 0x834a, "EeePC", 1),
>   	SND_PCI_QUIRK(0x8086, 0xd613, "Intel", 1),
>   	{}
>   };
> 

      reply	other threads:[~2011-05-19 16:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-19 14:32 Madis Janson
2011-05-19 16:18 ` Takashi Iwai
2011-05-19 16:31   ` Madis Janson
2011-05-19 16:33     ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hpqnetztg.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madis@cyber.ee \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®