From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752516Ab1A2LB7 (ORCPT ); Sat, 29 Jan 2011 06:01:59 -0500 Received: from cantor.suse.de ([195.135.220.2]:44434 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750784Ab1A2LB6 (ORCPT ); Sat, 29 Jan 2011 06:01:58 -0500 Date: Sat, 29 Jan 2011 12:01:55 +0100 Message-ID: From: Takashi Iwai To: Jesper Juhl Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Jaroslav Kysela , Wu Fengguang Subject: Re: [PATCH] sound, hda_eld: suspicious sizeof() in call to snd_print_pcm_bits() In-Reply-To: References: User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sat, 29 Jan 2011 01:40:04 +0100 (CET), Jesper Juhl wrote: > > In hdmi_show_short_audio_desc() we call snd_print_pcm_bits() like this: > snd_print_pcm_bits(a->sample_bits, buf2 + 8, sizeof(buf2 - 8)); > that last argument is supposed to be the size of the buffer that > snd_print_pcm_bits() writes to, so I believe it should be this: > snd_print_pcm_bits(a->sample_bits, buf2 + 8, sizeof(buf2) - 8); > > Signed-off-by: Jesper Juhl Thanks, but this was already fixed in sound git tree and included in the pending pull request for 2.6.38. Takashi > --- > hda_eld.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Compile tested only. I don't have relevant hardware. > > diff --git a/sound/pci/hda/hda_eld.c b/sound/pci/hda/hda_eld.c > index 4a66347..74b0560 100644 > --- a/sound/pci/hda/hda_eld.c > +++ b/sound/pci/hda/hda_eld.c > @@ -381,7 +381,7 @@ static void hdmi_show_short_audio_desc(struct cea_sad *a) > snd_print_pcm_rates(a->rates, buf, sizeof(buf)); > > if (a->format == AUDIO_CODING_TYPE_LPCM) > - snd_print_pcm_bits(a->sample_bits, buf2 + 8, sizeof(buf2 - 8)); > + snd_print_pcm_bits(a->sample_bits, buf2 + 8, sizeof(buf2) - 8); > else if (a->max_bitrate) > snprintf(buf2, sizeof(buf2), > ", max bitrate = %d", a->max_bitrate); > > > -- > Jesper Juhl http://www.chaosbits.net/ > Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html > Plain text mails only, please. >