From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752053Ab0GUM5H (ORCPT ); Wed, 21 Jul 2010 08:57:07 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60368 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756Ab0GUM5C (ORCPT ); Wed, 21 Jul 2010 08:57:02 -0400 Date: Wed, 21 Jul 2010 14:57:01 +0200 Message-ID: From: Takashi Iwai To: Christian Dietrich Cc: Jaroslav Kysela , Tejun Heo , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, vamos-dev@i4.informatik.uni-erlangen.de Subject: Re: [PATCH 3/3] sound/isa/gus: Remove dead CONFIG_SND_DEBUG_ROM In-Reply-To: References: User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 21 Jul 2010 14:36:02 +0200, Christian Dietrich wrote: > > CONFIG_SND_DEBUG_ROM doesn't exist in Kconfig, therefore it is never > defined and we can remove all references to it. If it should stay as a > debug flag, perhaps it shouldn't be named CONFIG_ > > Signed-off-by: Christian Dietrich This is rather a debug code, so it's often useful to keep as is. At bets, we can rename the ifdef without CONFIG_ prefix. thanks, Takashi > --- > sound/isa/gus/interwave.c | 8 -------- > 1 files changed, 0 insertions(+), 8 deletions(-) > > diff --git a/sound/isa/gus/interwave.c b/sound/isa/gus/interwave.c > index c7b80e4..ac60c7d 100644 > --- a/sound/isa/gus/interwave.c > +++ b/sound/isa/gus/interwave.c > @@ -442,19 +442,11 @@ static void __devinit snd_interwave_detect_memory(struct snd_gus_card * gus) > for (bank_pos = 0; bank_pos < 16L * 1024L * 1024L; bank_pos += 4L * 1024L * 1024L) { > for (i = 0; i < 8; ++i) > iwave[i] = snd_gf1_peek(gus, bank_pos + i); > -#ifdef CONFIG_SND_DEBUG_ROM > - printk(KERN_DEBUG "ROM at 0x%06x = %02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x\n", bank_pos, > - iwave[0], iwave[1], iwave[2], iwave[3], > - iwave[4], iwave[5], iwave[6], iwave[7]); > -#endif > if (strncmp(iwave, "INTRWAVE", 8)) > continue; /* first check */ > csum = 0; > for (i = 0; i < sizeof(struct rom_hdr); i++) > csum += snd_gf1_peek(gus, bank_pos + i); > -#ifdef CONFIG_SND_DEBUG_ROM > - printk(KERN_DEBUG "ROM checksum = 0x%x (computed)\n", csum); > -#endif > if (csum != 0) > continue; /* not valid rom */ > gus->gf1.rom_banks++; > -- > 1.7.0.4 >