From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1756210AbYERHzd@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756210AbYERHzd (ORCPT <rfc822;w@1wt.eu>);
	Sun, 18 May 2008 03:55:33 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752747AbYERHzY
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sun, 18 May 2008 03:55:24 -0400
Received: from cantor2.suse.de ([195.135.220.15]:52161 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752000AbYERHzX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 18 May 2008 03:55:23 -0400
Date: Sun, 18 May 2008 09:55:21 +0200
Message-ID: <s5hprrkkpw6.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       bugme-daemon@bugzilla.kernel.org, linux-kernel@vger.kernel.org,
       Ingo Molnar <mingo@elte.hu>, Stas Sergeev <stsp@aknet.ru>
Subject: Re: [Bugme-new] [Bug 10701] New: snd_pcsp lockdep warning
In-Reply-To: <alpine.LFD.1.10.0805171720310.14337@apollo.tec.linutronix.de>
References: <bug-10701-10286@http.bugzilla.kernel.org/>
	<20080515110244.6e15d4c3.akpm@linux-foundation.org>
	<alpine.LFD.1.10.0805161338500.3255@apollo.tec.linutronix.de>
	<20080516103827.0d5ab023.akpm@linux-foundation.org>
	<alpine.LFD.1.10.0805162132050.3255@apollo.tec.linutronix.de>
	<s5hwsltm4bu.wl%tiwai@suse.de>
	<alpine.LFD.1.10.0805171720310.14337@apollo.tec.linutronix.de>
User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.7
 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki)
 (+CVS-20070806) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Sat, 17 May 2008 17:24:22 +0200 (CEST),
Thomas Gleixner wrote:
> 
> On Sat, 17 May 2008, Takashi Iwai wrote:
> > At Fri, 16 May 2008 21:32:49 +0200 (CEST),
> > Thomas Gleixner wrote:
> > > 
> > > On Fri, 16 May 2008, Andrew Morton wrote:
> > > > > So the author was well aware of locking problem and the whole code is
> > > > > just a stupid hack around the problem without solving it. This code is
> > > > > not at all suited for HRTIMER_CB_IRQSAFE.
> > > > 
> > > > You sound impressed!  So what's the fix?  HRTIMER_CB_SOFTIRQ?
> > > 
> > > Yeah, impressed by creativity. HRTIMER_CB_SOFTIRQ should be the right
> > > thing.
> > 
> > Well, it'd be basically a similar way like snd-pcsp currently does ("a
> > stupid hack" :)  But, it's good to have a fix, anyway, since this
> > sounds like a generic problem with a callback in a spinlock.  If the
> > callback requires another own lock, this can easily lead to a AB/BA
> > deadlock.  Actually, ALSA PCM core had sometimes similar problems,
> > too.
> 
> HRTIMER_CB_SOFTIRQ is not a stupid hack :) It's the default for
> hrtimers and it does not hold any locks when calling the callback. We
> really want to avoid tons of callbacks in the timer interrupt itself.

Yes, this would be an easy workaround for snd-pcsp problem, I guess.

A better fix would be to make snd-pcsp hrtimer calback just change the
pc-speaker port (0x61 and 0x42) and update the position.  These should
be really fast path.  Then, occasionally invoke a tasklet that will
call snd_pcm_period_elapsed(), which could be a (relatively) slow
path and lead to a spinlock mess.


thanks,

Takashi