From: Takashi Iwai <tiwai@suse.de>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: Adel Gadllah <adel.gadllah@gmail.com>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] snd-hda-intel: don't print using snd_printdd on device open
Date: Mon, 18 Feb 2008 07:48:03 +0100 [thread overview]
Message-ID: <s5hpruuvjz0.wl%tiwai@suse.de> (raw)
In-Reply-To: <47B8F020.7030300@redhat.com>
At Sun, 17 Feb 2008 21:40:32 -0500,
Chuck Ebbert wrote:
>
> From: Adel Gadllah <adel.gadllah@gmail.com>
>
> snd-hda-intel: don't print using snd_printdd on device open
>
> When CONFIG_SND_DEBUG_DETECT is set the hda-intel driver prints verbose
> info like this:
>
> ALSA sound/pci/hda/hda_intel.c:1259: azx_pcm_prepare: bufsize=0x4400,
> fragsize=0x1100, format=0x11
> ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x7,
> stream=0x5, channel=0, format=0x11
> ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3,
> stream=0x5, channel=0, format=0x11
> ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3,
> stream=0x0, channel=0, format=0x0
> ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x7,
> stream=0x0, channel=0, format=0x0
> ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3,
> stream=0x0, channel=0, format=0x0
>
> Don't print anything in functions that get called when the device gets
> opened/prepared for output.
Why? This debug option is explicitly for debugging purposes, and I
see no reason why such behavior is prohibited.
Takashi
next prev parent reply other threads:[~2008-02-18 6:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-17 10:31 Adel Gadllah
2008-02-18 2:40 ` Chuck Ebbert
2008-02-18 6:48 ` Takashi Iwai [this message]
2008-02-18 6:54 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hpruuvjz0.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=adel.gadllah@gmail.com \
--cc=cebbert@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®