From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1751331AbWEMPgZ@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751331AbWEMPgZ (ORCPT <rfc822;willy@w.ods.org>);
	Sat, 13 May 2006 11:36:25 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751332AbWEMPgZ
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sat, 13 May 2006 11:36:25 -0400
Received: from ns2.suse.de ([195.135.220.15]:30892 "EHLO mx2.suse.de")
	by vger.kernel.org with ESMTP id S1751331AbWEMPgZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 13 May 2006 11:36:25 -0400
Date: Sat, 13 May 2006 17:36:23 +0200
Message-ID: <s5hpsiivsw8.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>, Ingo Molnar <mingo@elte.hu>,
       akpm@osdl.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Silly bitmap size accounting fix
In-Reply-To: <Pine.LNX.4.58.0605131010110.27003@gandalf.stny.rr.com>
References: <Pine.LNX.4.58.0605120403540.28581@gandalf.stny.rr.com>
	<20060512091451.GA18145@elte.hu>
	<4465386B.9090804@yahoo.com.au>
	<Pine.LNX.4.58.0605131010110.27003@gandalf.stny.rr.com>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta25)
 (eggplant) (+CVS-20060326) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

At Sat, 13 May 2006 10:12:11 -0400 (EDT),
Steven Rostedt wrote:
> 
> 
> Index: linux-2.6.17-rc3-mm1/kernel/sched.c
> ===================================================================
> --- linux-2.6.17-rc3-mm1.orig/kernel/sched.c	2006-05-12 04:02:32.000000000 -0400
> +++ linux-2.6.17-rc3-mm1/kernel/sched.c	2006-05-13 10:09:15.000000000 -0400
> @@ -192,6 +192,10 @@ static inline unsigned int task_timeslic
>   * These are the runqueue data structures:
>   */
> 
> +/*
> + * Calculate BITMAP_SIZE.
> + *  The bitmask holds MAX_PRIO bits + 1 for the delimiter.
> + */
>  #define BITMAP_SIZE ((((MAX_PRIO+1+7)/8)+sizeof(long)-1)/sizeof(long))

What's wrong with BITS_TO_LONG(MAX_PRIO + 1) ?

Or, using DECLARE_BITMAP() in struct prio_array would be easier...


Takashi