From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88BF0C433ED for ; Sun, 25 Apr 2021 08:19:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63C2E613C4 for ; Sun, 25 Apr 2021 08:19:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229619AbhDYIT7 (ORCPT ); Sun, 25 Apr 2021 04:19:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:56024 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbhDYIT6 (ORCPT ); Sun, 25 Apr 2021 04:19:58 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 60636B01E; Sun, 25 Apr 2021 08:19:18 +0000 (UTC) Date: Sun, 25 Apr 2021 10:19:18 +0200 Message-ID: From: Takashi Iwai To: Vitaly Rodionov Cc: Jaroslav Kysela , Takashi Iwai , , , , Stefan Binding , You-Sheng Yang Subject: Re: [PATCH v1 1/2] ALSA: hda/cirrus: Set Initial DMIC volume for Bullseye to 16% In-Reply-To: <20210424143244.639125-2-vitalyr@opensource.cirrus.com> References: <20210424143244.639125-1-vitalyr@opensource.cirrus.com> <20210424143244.639125-2-vitalyr@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 24 Apr 2021 16:32:43 +0200, Vitaly Rodionov wrote: > > From: Stefan Binding > > Tested on DELL Inspiron-3505, DELL Inspiron-3501, DELL Inspiron-3500 Could you give a bit more descriptions why this patch is needed? And what do you mean 16%? The only meaningful measure is dB in the h/w spec. Last but not least, why this value was chosen? thanks, Takashi > > Signed-off-by: Stefan Binding > Signed-off-by: Vitaly Rodionov > BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1923557 > Reported-and-tested-by: You-Sheng Yang > --- > sound/pci/hda/patch_cirrus.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/sound/pci/hda/patch_cirrus.c b/sound/pci/hda/patch_cirrus.c > index 5d57096b3a95..d6cf93b7483c 100644 > --- a/sound/pci/hda/patch_cirrus.c > +++ b/sound/pci/hda/patch_cirrus.c > @@ -2172,6 +2172,10 @@ static void cs8409_cs42l42_fixups(struct hda_codec *codec, > (get_wcaps(codec, CS8409_CS42L42_AMIC_PIN_NID) | AC_WCAP_UNSOL_CAP)); > break; > case HDA_FIXUP_ACT_PROBE: > + > + if (codec->fixup_id == CS8409_BULLSEYE) > + snd_hda_codec_amp_init_stereo(codec, CS8409_CS42L42_DMIC_ADC_PIN_NID, > + HDA_INPUT, 0, 0xff, 0x19); > snd_hda_gen_add_kctl(&spec->gen, > NULL, &cs8409_cs42l42_hp_volume_mixer); > snd_hda_gen_add_kctl(&spec->gen, > -- > 2.25.1 >