From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73064C2D0B1 for ; Thu, 6 Feb 2020 13:48:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A471218AC for ; Thu, 6 Feb 2020 13:48:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728208AbgBFNsE (ORCPT ); Thu, 6 Feb 2020 08:48:04 -0500 Received: from mx2.suse.de ([195.135.220.15]:36218 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727060AbgBFNsE (ORCPT ); Thu, 6 Feb 2020 08:48:04 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 48E8EAC5F; Thu, 6 Feb 2020 13:48:02 +0000 (UTC) Date: Thu, 06 Feb 2020 14:48:01 +0100 Message-ID: From: Takashi Iwai To: Kai Vehmanen Cc: kbuild test robot , Takashi Iwai , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Mark Brown , Pierre-Louis Bossart Subject: Re: sound/pci/hda/patch_hdmi.c:1086: undefined reference to `snd_hda_get_num_devices' In-Reply-To: References: <202002061809.r3UYBZGx%lkp@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 06 Feb 2020 14:40:17 +0100, Kai Vehmanen wrote: > > Hey, > > On Thu, 6 Feb 2020, kbuild test robot wrote: > > > ld: sound/pci/hda/patch_hdmi.o: in function `intel_not_share_assigned_cvt': > > >> sound/pci/hda/patch_hdmi.c:1086: undefined reference to `snd_hda_get_num_devices' > > >> ld: sound/pci/hda/patch_hdmi.c:1098: undefined reference to `snd_hda_get_dev_select' > > >> ld: sound/pci/hda/patch_hdmi.c:1099: undefined reference to `snd_hda_set_dev_select' > > hmm, this seems similar case as the previous one today w.r.t > hda_dsp_common.c:76. Patch_hdmi.c is built-in while snd-hda is a module. > Maybe we need to just drop the dependency from the ASoC board files to > SND_HDA_CODEC_HDMI. We don't have one for SND_HDA_CODEC either. The problem is that SOF tries to do reverse-select the legacy HD-audio codec, but it doesn't work in general. Or it must be done very carefully. If something gets selected, all dependencies have to be reverse-selected, too. But the legacy HDA is built up in a way of standard top-down selection (i.e. SND_HDA_CODEC_* depends on SND_HDA, not other way round). Takashi