From: Takashi Iwai <tiwai@suse.de>
To: "Kangjie Lu" <kjlu@umn.edu>
Cc: <alsa-devel@alsa-project.org>, "Jaroslav Kysela" <perex@perex.cz>,
<pakki001@umn.edu>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gus: add a check of the status of snd_ctl_add
Date: Tue, 01 Jan 2019 09:53:52 +0100 [thread overview]
Message-ID: <s5hr2dwiwrj.wl-tiwai@suse.de> (raw)
In-Reply-To: <20181226014052.70937-1-kjlu@umn.edu>
On Wed, 26 Dec 2018 02:40:51 +0100,
Kangjie Lu wrote:
>
> snd_ctl_add() could fail, so let's check its status and issue an error
> message if it indeed fails.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
The function itself prints the error in most of useful cases, so the
extra error here would be superfluous.
thanks,
Takashi
prev parent reply other threads:[~2019-01-01 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 1:40 Kangjie Lu
2019-01-01 8:53 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hr2dwiwrj.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®