From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=i6x1=N7=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id BBFABC43441
	for <linux-kernel@archiver.kernel.org>; Tue, 20 Nov 2018 07:07:44 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id AC23C20685
	for <linux-kernel@archiver.kernel.org>; Tue, 20 Nov 2018 07:07:13 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC23C20685
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1732792AbeKTRer (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 20 Nov 2018 12:34:47 -0500
Received: from mx2.suse.de ([195.135.220.15]:42090 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1726840AbeKTReq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Nov 2018 12:34:46 -0500
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay1.suse.de (unknown [195.135.220.254])
        by mx1.suse.de (Postfix) with ESMTP id 584A7AE56;
        Tue, 20 Nov 2018 07:07:10 +0000 (UTC)
Date:   Tue, 20 Nov 2018 08:07:09 +0100
Message-ID: <s5hr2fgfcrm.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Pavel Machek" <pavel@ucw.cz>
Cc:     "Ayman Bagabas" <ayman.bagabas@gmail.com>,
        <alsa-devel@alsa-project.org>, "Hui Wang" <hui.wang@canonical.com>,
        "Andy Shevchenko" <andy@infradead.org>,
        "Darren Hart" <dvhart@infradead.org>,
        "Jaroslav Kysela" <perex@perex.cz>,
        "Kailang Yang" <kailang@realtek.com>,
        <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED
In-Reply-To: <20181119235713.GB7367@amd>
References: <20181108171701.4444-1-ayman.bagabas@gmail.com>
        <20181108171701.4444-4-ayman.bagabas@gmail.com>
        <20181119235713.GB7367@amd>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 20 Nov 2018 00:57:13 +0100,
Pavel Machek wrote:
> 
> > +#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP)
> > +#include <linux/platform_data/x86/huawei_wmi.h>
> > +
> > +static int (*huawei_wmi_micmute_led_set_func)(bool);
> > +
> 
> So we should not be doing this.
> 
> Thinkpad ACPI module exports its LEDs there, for example.

Both thinkpad_acpi and dell_laptop provide the interface to HD-audio
in the very same way like this.


thanks,

Takashi