From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C670C43142 for ; Thu, 2 Aug 2018 05:27:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D8B8208DA for ; Thu, 2 Aug 2018 05:27:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D8B8208DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726250AbeHBHQd (ORCPT ); Thu, 2 Aug 2018 03:16:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:49974 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726002AbeHBHQc (ORCPT ); Thu, 2 Aug 2018 03:16:32 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7EC40ADE3; Thu, 2 Aug 2018 05:27:09 +0000 (UTC) Date: Thu, 02 Aug 2018 07:27:08 +0200 Message-ID: From: Takashi Iwai To: "Wei Yongjun" Cc: "Jorge Sanjuan" , "Michael Drake" , "Ruslan Bilovol" , "Greg Kroah-Hartman" , "Jaroslav Kysela" , "MarkusElfring" , , , Subject: Re: [PATCH -next] ALSA: usb-audio: Fix invalid use of sizeof in parse_uac_endpoint_attributes() In-Reply-To: <1533184262-148619-1-git-send-email-weiyongjun1@huawei.com> References: <1533184262-148619-1-git-send-email-weiyongjun1@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 02 Aug 2018 06:31:02 +0200, Wei Yongjun wrote: > > sizeof() when applied to a pointer typed expression gives the > size of the pointer, not that of the pointed data. > > Fixes: 7edf3b5e6a45 ("ALSA: usb-audio: AudioStreaming Power Domain parsing") > Signed-off-by: Wei Yongjun Applied, thanks. Takashi > --- > sound/usb/stream.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/usb/stream.c b/sound/usb/stream.c > index 8fe3b0e..67cf849 100644 > --- a/sound/usb/stream.c > +++ b/sound/usb/stream.c > @@ -1037,7 +1037,7 @@ static int parse_uac_endpoint_attributes(struct snd_usb_audio *chip, > fp->rate_max = UAC3_BADD_SAMPLING_RATE; > fp->rates = SNDRV_PCM_RATE_CONTINUOUS; > > - pd = kzalloc(sizeof(pd), GFP_KERNEL); > + pd = kzalloc(sizeof(*pd), GFP_KERNEL); > if (!pd) { > kfree(fp->rate_table); > kfree(fp); > >