From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-646324-1518418797-2-5506305730614985161 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='de', MailFrom='org' X-Spam-charsets: plain='US-ASCII' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1518418796; b=jWeq1pYFe8X4mAI83sehYzziKWs+MtLODJhCUMyABfE7luN a8UfLO5czNYKPeUXWmm257JZWu/mqSH2HyXkPPzyrHTWdqJpIfZL+Ha97aHTpMy+ e9btf2PcKRe/NpzgnKOCljtO1j3XfXGb1thtVnCzx97125TVE+luIQUeBFv5p0MQ z6RDwfC8WNWMh3Bz1Ic4wtLKGnU8MQk8zeMtqJA+mswqTrLyAKvbHzSuRoES1aBD uMRwzY1use/i4tNu1QdKoe28mFR6bPJ+F0BFrKCqF6SU054t3paRw1xOoHhcYZIj zADyq/bar+PStxHP/pALSPUmKQd63MMiyJn5fBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:message-id:from:to:cc:subject :in-reply-to:references:mime-version:content-type:sender :list-id; s=arctest; t=1518418796; bh=m3iFDFxhJPIqDibPke50CzyvL1 ZPqPtYSPj4jk4jUSU=; b=YgyJhB6lwyNZKwnZqU/CCXbHrZ5szyZI1Ubb2ecbiG 8+9JIx/fV9MaDvw1PVK6s1uNteC7gT0jXMJr6wp3iq4M8OSiOcBJNZHRq6GOW6kR laWAhR/DYkzZCHMfChrGTjmvwI9RQrGrvUS7Y3EJ3gs0LXVMKY+Ecl9pVxjvFiDv UXzurU929cDzHmSoe46/qY+BDLR3bIm6B2B5Q0Fv5xO+iLm9afAIFz4uVUdEb07z Tab9hv/ztB6IRjE3HaEslELhcEebWDWyusjhjFUmX1aXnmCMfkFUmC+R77HxxgwT PnlhdOqCH3l7j01YggwCMaJ3s/GSlBrgn6oNOx5fEXWw== ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=suse.de; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=suse.de header.result=pass header_is_org_domain=yes Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=suse.de; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=suse.de header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753812AbeBLG7y (ORCPT ); Mon, 12 Feb 2018 01:59:54 -0500 Received: from mx2.suse.de ([195.135.220.15]:57690 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753808AbeBLG7x (ORCPT ); Mon, 12 Feb 2018 01:59:53 -0500 Date: Mon, 12 Feb 2018 07:59:51 +0100 Message-ID: From: Takashi Iwai To: Ben Hutchings Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH 3.2 57/79] ALSA: usb-audio: Fix potential zero-division at parsing FU In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Sun, 11 Feb 2018 05:20:06 +0100, Ben Hutchings wrote: > > 3.2.99-rc1 review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Takashi Iwai > > commit 8428a8ebde2db1e988e41a58497a28beb7ce1705 upstream. Please drop this. This patch is broken, and was reverted in the later commit 3c02a6d94665. thanks, Takashi > > parse_audio_feature_unit() contains a code dividing potentially with > zero when a malformed FU descriptor is passed. Although there is > already a sanity check, it checks only the value zero, hence it can > still lead to a zero-division when a value 1 is passed there. > > Fix it by correcting the sanity check (and the error message > thereof). > > Fixes: 23caaf19b11e ("ALSA: usb-mixer: Add support for Audio Class v2.0") > Signed-off-by: Takashi Iwai > [bwh: Backported to 3.2: adjust context] > Signed-off-by: Ben Hutchings > --- > sound/usb/mixer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/sound/usb/mixer.c > +++ b/sound/usb/mixer.c > @@ -1262,9 +1262,9 @@ static int parse_audio_feature_unit(stru > return -EINVAL; > } > csize = hdr->bControlSize; > - if (!csize) { > + if (csize <= 1) { > snd_printdd(KERN_ERR "usbaudio: unit %u: " > - "invalid bControlSize == 0\n", unitid); > + "invalid bControlSize <= 1\n", unitid); > return -EINVAL; > } > channels = (hdr->bLength - 7) / csize - 1; >