From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751352AbdE3JDM (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 May 2017 05:03:12 -0400
Received: from mx2.suse.de ([195.135.220.15]:51371 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1750908AbdE3JDL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 May 2017 05:03:11 -0400
Date: Tue, 30 May 2017 11:03:09 +0200
Message-ID: <s5hr2z6emya.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Bhumika Goyal <bhumirks@gmail.com>, alsa-devel@alsa-project.org,
        lgirdwood@gmail.com, broonie@kernel.org, clemens@ladisch.de,
        linuxppc-dev@lists.ozlabs.org, perex@perex.cz,
        johannes@sipsolutions.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const
In-Reply-To: <alpine.DEB.2.20.1705301056200.2981@hadrien>
References: <1495896375-30855-1-git-send-email-bhumirks@gmail.com>
        <s5hvaoiencx.wl-tiwai@suse.de>
        <alpine.DEB.2.20.1705301056200.2981@hadrien>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 30 May 2017 10:56:39 +0200,
Julia Lawall wrote:
> 
> 
> 
> On Tue, 30 May 2017, Takashi Iwai wrote:
> 
> > On Sat, 27 May 2017 16:46:15 +0200,
> > Bhumika Goyal wrote:
> > >
> > > Declare snd_kcontrol_new structures as const as they are only passed an
> > > argument to the function snd_ctl_new1. This argument is of type const,
> > > so snd_kcontrol_new structures having this property can be made const.
> > > Done using Coccinelle:
> > >
> > > @r disable optional_qualifier@
> > > identifier x;
> > > position p;
> > > @@
> > > static struct snd_kcontrol_new x@p={...};
> > >
> > > @ok@
> > > identifier r.x;
> > > position p;
> > > @@
> > > snd_ctl_new1(&x@p,...)
> > >
> > > @bad@
> > > position p != {r.p,ok.p};
> > > identifier r.x;
> > > @@
> > > x@p
> > >
> > > @depends on !bad disable optional_qualifier@
> > > identifier r.x;
> > > @@
> > > +const
> > > struct snd_kcontrol_new x;
> > >
> > > Cross compiled these files:
> > > sound/aoa/codecs/tas.c - powerpc
> > > sound/mips/{hal2.c/sgio2audio.c} - mips
> > > sound/ppc/{awacs.c/beep.c/tumbler.c} - powerpc
> > > sound/soc/sh/siu_dai.c - sh
> > > Could not find an architecture to compile sound/sh/aica.c.
> > >
> > > Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> >
> > Applied now, as it looks safe enough.  But I prefer splitting to
> > individual patches, so please try to do that at the next time.
> 
> Individual patches in a series?

Yes.


Takashi