From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S941489AbcKQLrZ (ORCPT <rfc822;w@1wt.eu>);
        Thu, 17 Nov 2016 06:47:25 -0500
Received: from mx2.suse.de ([195.135.220.15]:40518 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S2992523AbcKQLrQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 17 Nov 2016 06:47:16 -0500
Date: Thu, 17 Nov 2016 12:47:11 +0100
Message-ID: <s5hr36awcow.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Joe Perches <joe@perches.com>
Cc: Takashi Sakamoto <o-takashi@sakamocchi.jp>,
        alsa-devel <alsa-devel@alsa-project.org>,
        Clemens Ladisch <clemens@ladisch.de>, Takashi Iwai <tiwai@suse.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] sound: bebop: strncmp length oddity
In-Reply-To: <1477777020.23018.8.camel@perches.com>
References: <1477777020.23018.8.camel@perches.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 29 Oct 2016 23:37:00 +0200,
Joe Perches wrote:
> 
> 15 isn't the length of the string, is that really what's desired?
> 
> linux/next/sound/firewire/bebob/bebop.c
> 
> -----------------------------
> 
> static bool
> check_audiophile_booted(struct fw_unit *unit)
> {
> 	char name[24] = {0};
> 
> 	if (fw_csr_string(unit->directory, CSR_MODEL, name, sizeof(name)) < 0)
> 		return false;
> 
> 	return strncmp(name, "FW Audiophile Bootloader", 15) != 0;
> }

Indeed it looks bogus.  Even "FW...." string is already 24 letters, so
it's over name[] array size.

Sakamoto-san, could you fix it properly?


thanks,

Takashi