From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754042AbcBAQST (ORCPT ); Mon, 1 Feb 2016 11:18:19 -0500 Received: from mx2.suse.de ([195.135.220.15]:42555 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752312AbcBAQSR (ORCPT ); Mon, 1 Feb 2016 11:18:17 -0500 Date: Mon, 01 Feb 2016 17:18:08 +0100 Message-ID: From: Takashi Iwai To: "Shuah Khan" Cc: "Mauro Carvalho Chehab" , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 01/31] uapi/media.h: Declare interface types for ALSA In-Reply-To: <56AF82D7.1020900@osg.samsung.com> References: <20160128125941.143f67d0@recife.lan> <56AF82D7.1020900@osg.samsung.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 01 Feb 2016 17:07:51 +0100, Shuah Khan wrote: > > On 01/28/2016 07:59 AM, Mauro Carvalho Chehab wrote: > > Em Wed, 6 Jan 2016 13:26:50 -0700 > > Shuah Khan escreveu: > > > >> From: Mauro Carvalho Chehab > >> > >> Declare the interface types to be used on alsa for the new > >> G_TOPOLOGY ioctl. > >> > >> Signed-off-by: Mauro Carvalho Chehab > >> --- > >> drivers/media/media-entity.c | 12 ++++++++++++ > >> include/uapi/linux/media.h | 8 ++++++++ > >> 2 files changed, 20 insertions(+) > >> > >> diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c > >> index eb38bc3..6e02d19 100644 > >> --- a/drivers/media/media-entity.c > >> +++ b/drivers/media/media-entity.c > >> @@ -65,6 +65,18 @@ static inline const char *intf_type(struct media_interface *intf) > >> return "v4l2-subdev"; > >> case MEDIA_INTF_T_V4L_SWRADIO: > >> return "swradio"; > >> + case MEDIA_INTF_T_ALSA_PCM_CAPTURE: > >> + return "pcm-capture"; > >> + case MEDIA_INTF_T_ALSA_PCM_PLAYBACK: > >> + return "pcm-playback"; > >> + case MEDIA_INTF_T_ALSA_CONTROL: > >> + return "alsa-control"; > >> + case MEDIA_INTF_T_ALSA_COMPRESS: > >> + return "compress"; > >> + case MEDIA_INTF_T_ALSA_RAWMIDI: > >> + return "rawmidi"; > >> + case MEDIA_INTF_T_ALSA_HWDEP: > >> + return "hwdep"; > >> default: > >> return "unknown-intf"; > >> } > >> diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h > >> index cacfceb..75cbe92 100644 > >> --- a/include/uapi/linux/media.h > >> +++ b/include/uapi/linux/media.h > >> @@ -252,6 +252,7 @@ struct media_links_enum { > >> > >> #define MEDIA_INTF_T_DVB_BASE 0x00000100 > >> #define MEDIA_INTF_T_V4L_BASE 0x00000200 > >> +#define MEDIA_INTF_T_ALSA_BASE 0x00000300 > >> > >> /* Interface types */ > >> > >> @@ -267,6 +268,13 @@ struct media_links_enum { > >> #define MEDIA_INTF_T_V4L_SUBDEV (MEDIA_INTF_T_V4L_BASE + 3) > >> #define MEDIA_INTF_T_V4L_SWRADIO (MEDIA_INTF_T_V4L_BASE + 4) > >> > >> +#define MEDIA_INTF_T_ALSA_PCM_CAPTURE (MEDIA_INTF_T_ALSA_BASE) > >> +#define MEDIA_INTF_T_ALSA_PCM_PLAYBACK (MEDIA_INTF_T_ALSA_BASE + 1) > >> +#define MEDIA_INTF_T_ALSA_CONTROL (MEDIA_INTF_T_ALSA_BASE + 2) > >> +#define MEDIA_INTF_T_ALSA_COMPRESS (MEDIA_INTF_T_ALSA_BASE + 3) > >> +#define MEDIA_INTF_T_ALSA_RAWMIDI (MEDIA_INTF_T_ALSA_BASE + 4) > >> +#define MEDIA_INTF_T_ALSA_HWDEP (MEDIA_INTF_T_ALSA_BASE + 5) > > > > Patch looks ok, but please document the new media interfaces at KernelDoc > > documentation. > > > > Hi Takashi, > > If you are okay with these changes, could you please > Ack this patch. I am addressing documentation comment > from Mauro. Well, the available ALSA devices are: CONTROL SEQUENCER TIMER COMPRESS HWDEP RAWMIDI PCM_PLAYBACK PCM_CAPTURE as found in sound/minors.h. Any reason not to define for some of them? Takashi