From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753341AbaFXMRb (ORCPT ); Tue, 24 Jun 2014 08:17:31 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41902 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752949AbaFXMRa (ORCPT ); Tue, 24 Jun 2014 08:17:30 -0400 Date: Tue, 24 Jun 2014 14:17:28 +0200 Message-ID: From: Takashi Iwai To: Rickard Strandqvist Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: oss: mpu401.c: Cleaning up missing break in a case In-Reply-To: <1403606975-12827-1-git-send-email-rickard_strandqvist@spectrumdigital.se> References: <1403606975-12827-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 24 Jun 2014 12:49:35 +0200, Rickard Strandqvist wrote: > > Added a missed break in a case statement > > This was found using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist Thanks, applied. Takashi > --- > sound/oss/mpu401.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/oss/mpu401.c b/sound/oss/mpu401.c > index 25e4609..400896b 100644 > --- a/sound/oss/mpu401.c > +++ b/sound/oss/mpu401.c > @@ -316,6 +316,7 @@ static int mpu_input_scanner(struct mpu_config *devc, unsigned char midic) > case 0xf6: > /* printk( "tune_request\n"); */ > devc->m_state = ST_INIT; > + break; > > /* > * Real time messages > -- > 1.7.10.4 >