From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757575AbaE2N57 (ORCPT ); Thu, 29 May 2014 09:57:59 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47239 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757048AbaE2N55 (ORCPT ); Thu, 29 May 2014 09:57:57 -0400 Date: Thu, 29 May 2014 15:57:55 +0200 Message-ID: From: Takashi Iwai To: Dan Carpenter Cc: Clemens Ladisch , Jaroslav Kysela , Takashi Sakamoto , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch 2/2] ALSA: fireworks: small leak on error path In-Reply-To: <20140528164246.GC1824@mwanda> References: <20140528164246.GC1824@mwanda> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 28 May 2014 19:42:46 +0300, Dan Carpenter wrote: > > There was a typo here so we return directly instead of freeing "hwinfo". > > Signed-off-by: Dan Carpenter Applied, thanks. Takashi > > diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c > index 8e856cc..996fdc4 100644 > --- a/sound/firewire/fireworks/fireworks.c > +++ b/sound/firewire/fireworks/fireworks.c > @@ -157,7 +157,7 @@ get_hardware_info(struct snd_efw *efw) > /* Hardware metering. */ > if (hwinfo->phys_in_grp_count > HWINFO_MAX_CAPS_GROUPS || > hwinfo->phys_out_grp_count > HWINFO_MAX_CAPS_GROUPS) { > - return -EIO; > + err = -EIO; > goto end; > } > efw->phys_in = hwinfo->phys_in; >