From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934232AbaDITI3 (ORCPT ); Wed, 9 Apr 2014 15:08:29 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34656 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933354AbaDITI1 (ORCPT ); Wed, 9 Apr 2014 15:08:27 -0400 Date: Wed, 09 Apr 2014 21:08:25 +0200 Message-ID: From: Takashi Iwai To: Tim Gardner Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jaroslav Kysela , Eldad Zack , Daniel Mack , Clemens Ladisch Subject: Re: [PATCH linux-next] ALSA: usb-audio: Suppress repetitive debug messages from retire_playback_urb() In-Reply-To: <1397064644-71907-1-git-send-email-tim.gardner@canonical.com> References: <1397064644-71907-1-git-send-email-tim.gardner@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 9 Apr 2014 11:30:44 -0600, Tim Gardner wrote: > > BugLink: http://bugs.launchpad.net/bugs/1305133 > > Malfunctioning or slow devices can cause a flood of dmesg SPAM. > > I've ignored checkpatch.pl complaints about the use of printk_ratelimit() in favour > of prior art in sound/usb/pcm.c. > > WARNING: Prefer printk_ratelimited or pr__ratelimited to printk_ratelimit > + if (printk_ratelimit() && > > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Eldad Zack > Cc: Daniel Mack > Cc: Clemens Ladisch > Signed-off-by: Tim Gardner Applied, thanks. Takashi > --- > sound/usb/pcm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c > index 49de5c1..131336d 100644 > --- a/sound/usb/pcm.c > +++ b/sound/usb/pcm.c > @@ -1501,7 +1501,8 @@ static void retire_playback_urb(struct snd_usb_substream *subs, > * The error should be lower than 2ms since the estimate relies > * on two reads of a counter updated every ms. > */ > - if (abs(est_delay - subs->last_delay) * 1000 > runtime->rate * 2) > + if (printk_ratelimit() && > + abs(est_delay - subs->last_delay) * 1000 > runtime->rate * 2) > dev_dbg(&subs->dev->dev, > "delay: estimated %d, actual %d\n", > est_delay, subs->last_delay); > -- > 1.7.9.5 >