From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752667Ab3LXOcU (ORCPT ); Tue, 24 Dec 2013 09:32:20 -0500 Received: from cantor2.suse.de ([195.135.220.15]:41494 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752201Ab3LXOcS (ORCPT ); Tue, 24 Dec 2013 09:32:18 -0500 Date: Tue, 24 Dec 2013 15:32:17 +0100 Message-ID: From: Takashi Iwai To: Ming Lei Cc: Paul Bolle , Neil Horman , Greg Kroah-Hartman , Linux Kernel Mailing List Subject: Re: firmware: new "platform microcode" warning in v3.13-rc1+ In-Reply-To: References: <1385919125.7199.17.camel@x41.thuisdomein> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 24 Dec 2013 09:15:09 +0800, Ming Lei wrote: > > Hi, > > On Mon, Dec 2, 2013 at 1:32 AM, Paul Bolle wrote: > > 0) Booting v3.13-rc1 and v3.13-rc2 triggers two new warnings on an > > (outdated, I'm afraid) ThinkPad X41: > > [...] > > <6>[ 16.746119] libipw: 802.11 data/management/control stack, git-1.1.13 > > <6>[ 16.746125] libipw: Copyright (C) 2004-2005 Intel Corporation > > <4>[ 16.761998] platform microcode: Direct firmware load failed with error -2 > > <4>[ 16.762022] platform microcode: Falling back to user helper > > <6>[ 16.787885] ipw2200: Intel(R) PRO/Wireless 2200/2915 Network Driver, 1.2.2kmprq > > <6>[ 16.787895] ipw2200: Copyright(c) 2003-2006 Intel Corporation > > <6>[ 16.788741] ipw2200: Detected Intel PRO/Wireless 2915ABG Network Connection > > [...] > > > > (I've added the surrounding lines because they suggest this is about the > > firmware for that wireless device. Please note that this device appears > > to work no worse than it did under v3.12.) > > > > 1) These warnings can be traced back to commit 3e358ac2bb5b ("firmware: > > Be a bit more verbose about direct firmware loading failure"). > > Yes, the warning was introduced in the commit since Neil thought it > is needed. The current behavior isn't much useful as is, unfortunately. It just warns that the firmware loading failed, but it doesn't tell you *which* firmware failed. > > 2) Is there something I'm supposed to do to silence these warnings? If > > so, what would that be? If not, can these messages perhaps be downgraded > > to dev_info or dev_notice? > > Currently the messages are dumped via dev_warn(), and it is a bit difficult > to make policy about the warning: sounds like Neil need them, and you > don't like them, :-) IMO, dev_warning() is too much in a case like Intel wifi driver. It retries with different firmware revision when the latest firmware doesn't exist, so the missing firmware isn't always a problem. Takashi