From: Takashi Iwai <tiwai@suse.de>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Dave Jones <davej@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
x86@kernel.org, fenghua.yu@intel.com
Subject: Re: microcode loading got really slow.
Date: Thu, 23 May 2013 12:36:40 +0200 [thread overview]
Message-ID: <s5hr4gyvv7r.wl%tiwai@suse.de> (raw)
In-Reply-To: <CACVXFVMsTjSqvyVkZEPfWgHDUJ_mqwqWy=vydCsTvv7TS-EKiQ@mail.gmail.com>
At Thu, 23 May 2013 18:27:57 +0800,
Ming Lei wrote:
>
> On Thu, May 23, 2013 at 6:16 PM, Takashi Iwai <tiwai@suse.de> wrote:
> >
> > Thinking on this again, if the user-space continues to be broken in
> > that point, we should provide request_firmware() variant without udev,
> > e.g. request_firmware_direct(), and use it in known places like this?
>
> As anish said, it has been already there,
No, f/w loader always fall back to user mode helper, as long as its
support is built in. And doing that for microcode driver in that code
path isn't only superfluous but also broken due to request_firmware
call in module init.
> wrt. this problem, I think we
> need to know why the direct loading is failed.
The reason is obvious: the requested f/w file doesn't exist.
And it's fine, because the microcode update is an optional operation.
If no f/w file is found, it's not handled as an error. It just means
that no need to update, continuing to work.
Takashi
next prev parent reply other threads:[~2013-05-23 10:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 23:03 Dave Jones
2013-05-22 19:03 ` H. Peter Anvin
2013-05-22 20:00 ` Dave Jones
2013-05-22 20:09 ` H. Peter Anvin
2013-05-23 0:19 ` Dave Jones
2013-05-23 3:39 ` Dave Jones
2013-05-23 6:56 ` Takashi Iwai
2013-05-23 7:45 ` Ming Lei
2013-05-23 8:06 ` Takashi Iwai
2013-05-23 10:16 ` Takashi Iwai
2013-05-23 10:18 ` anish singh
2013-05-23 10:28 ` Takashi Iwai
2013-05-23 10:27 ` Ming Lei
2013-05-23 10:36 ` Takashi Iwai [this message]
2013-05-23 10:45 ` Ming Lei
2013-05-23 12:05 ` Takashi Iwai
2013-05-23 13:04 ` Ming Lei
2013-05-23 13:21 ` Takashi Iwai
2013-05-23 14:28 ` Ming Lei
2013-05-23 14:36 ` Takashi Iwai
2013-05-23 14:48 ` Dave Jones
2013-05-23 15:06 ` Takashi Iwai
2013-05-23 15:27 ` Ming Lei
2013-05-23 15:55 ` Dave Jones
2013-05-23 15:21 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hr4gyvv7r.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=davej@redhat.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®