From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757465Ab3AYQBV (ORCPT ); Fri, 25 Jan 2013 11:01:21 -0500 Received: from cantor2.suse.de ([195.135.220.15]:40852 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756103Ab3AYQBS (ORCPT ); Fri, 25 Jan 2013 11:01:18 -0500 Date: Fri, 25 Jan 2013 17:01:17 +0100 Message-ID: From: Takashi Iwai To: Ming Lei Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: Make user-mode helper optional In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 25 Jan 2013 11:12:03 +0800, Ming Lei wrote: > > On Tue, Jan 22, 2013 at 7:51 PM, Takashi Iwai wrote: > > Since 3.7 kernel, the firmware loader can read the firmware files > > directly, and the traditional user-mode helper is invoked only as a > > fallback. This seems working pretty well, and the next step would be > > to reduce the redundant user-mode helper stuff in future. > > The idea is good. > > > > > This patch is a preparation for that, to make the user-mode helper > > invocation optional via kconfig. Other than that, there is no > > functional change here. > > In fact, your patch does much code refactoring work, which isn't > strictly related with what you claimed in the commit log, at least > it should be separated from introducing FW_LOADER_USER_HELPER. > > So could you split the patch into several parts and let one part do one thing > so that we can review them a bit easily? Fair enough. Will submit the revised patches soon. > > Also it is not good to introduce too many '#ifdef #endif', IMO. Heh, that can be much worse :) thanks, Takashi