From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754529Ab1ILK5J (ORCPT <rfc822;w@1wt.eu>);
	Mon, 12 Sep 2011 06:57:09 -0400
Received: from cantor2.suse.de ([195.135.220.15]:42273 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752243Ab1ILK5H (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 12 Sep 2011 06:57:07 -0400
Date: Mon, 12 Sep 2011 12:57:06 +0200
Message-ID: <s5hr53m6nb1.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Clemens Ladisch <clemens@ladisch.de>, Felipe Balbi <balbi@ti.com>,
        Jaroslav Kysela <perex@perex.cz>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org,
        Linux USB Mailing List <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v2] sound: usb: mixer: increase control transfer timeout
In-Reply-To: <CABb+yY1aQtN2fHKDk9a1MoAra40PSg3kotUJMhGJt8sb7EqTgA@mail.gmail.com>
References: <20110829122320.GX13925@legolas.emea.dhcp.ti.com>
	<1314621110-19367-1-git-send-email-balbi@ti.com>
	<CABb+yY15qrszsbJSGGFra7mrVRO_oQPUhNT=U7TNpyoYikABPw@mail.gmail.com>
	<4E5B9CB0.4090708@ladisch.de>
	<CABb+yY1aQtN2fHKDk9a1MoAra40PSg3kotUJMhGJt8sb7EqTgA@mail.gmail.com>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Mon, 29 Aug 2011 19:52:09 +0530,
Jassi Brar wrote:
> 
> On Mon, Aug 29, 2011 at 7:35 PM, Clemens Ladisch <clemens@ladisch.de> wrote:
> 
> >> > +                                   buf, val_len, 1000) >= val_len) {
> >> > +                                   buf, val_len, 1000) >= 0) {
> >> > +                             !value, 0, NULL, 0, 1000);
> >> > +                             !value, 0, NULL, 0, 1000);
> >> > +                             value, index + 2, NULL, 0, 1000);
> >> > +                                     jacks[i].unitid << 8, buf, 3, 1000);
> >> > +                             50, 0, &new_status, 1, 1000);
> >>
> >> How about also converting to use a local define for timeout value ?
> >
> > ... now that _all_ calls to snd_usb_ctl_msg use the same timeout value,
> > we could just as well drop this parameter.
> Sounds better, esp when we have 9 arguments to snd_usb_ctl_msg!

Indeed, I'd like to see the reduced arguments, too.


thanks,

Takashi