From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754109Ab1HGPd1 (ORCPT ); Sun, 7 Aug 2011 11:33:27 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53569 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753690Ab1HGPdW (ORCPT ); Sun, 7 Aug 2011 11:33:22 -0400 Date: Sun, 07 Aug 2011 17:33:17 +0200 Message-ID: From: Takashi Iwai To: Thomas Meyer Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: asihpi - use kzalloc() In-Reply-To: <1312629983.5589.129.camel@localhost.localdomain> References: <1312629983.5589.129.camel@localhost.localdomain> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sat, 06 Aug 2011 13:26:20 +0200, Thomas Meyer wrote: > > From: Thomas Meyer > > > Use kzalloc rather than kmalloc followed by memset with 0 > > This considers some simple cases that are common and easy to validate > Note in particular that there are no ...s in the rule, so all of the > matched code has to be contiguous > > The semantic patch that makes this output is available > in scripts/coccinelle/api/alloc/kzalloc-simple.cocci. > > More information about semantic patching is available at > http://coccinelle.lip6.fr/ > > Signed-off-by: Thomas Meyer Applied now. Thanks. Takashi > --- > > diff -u -p a/sound/pci/asihpi/hpicmn.c b/sound/pci/asihpi/hpicmn.c > --- a/sound/pci/asihpi/hpicmn.c 2011-07-26 00:46:12.970154018 +0200 > +++ b/sound/pci/asihpi/hpicmn.c 2011-08-01 20:42:34.859285236 +0200 > @@ -631,13 +631,12 @@ struct hpi_control_cache *hpi_alloc_cont > if (!p_cache) > return NULL; > > - p_cache->p_info = > - kmalloc(sizeof(*p_cache->p_info) * control_count, GFP_KERNEL); > + p_cache->p_info = kzalloc(sizeof(*p_cache->p_info) * control_count, > + GFP_KERNEL); > if (!p_cache->p_info) { > kfree(p_cache); > return NULL; > } > - memset(p_cache->p_info, 0, sizeof(*p_cache->p_info) * control_count); > p_cache->cache_size_in_bytes = size_in_bytes; > p_cache->control_count = control_count; > p_cache->p_cache = p_dsp_control_buffer; > > >