From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755678Ab1DTTZX (ORCPT ); Wed, 20 Apr 2011 15:25:23 -0400 Received: from cantor.suse.de ([195.135.220.2]:45242 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751984Ab1DTTZW (ORCPT ); Wed, 20 Apr 2011 15:25:22 -0400 Date: Wed, 20 Apr 2011 21:25:20 +0200 Message-ID: From: Takashi Iwai To: Mike Waychison Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Raymond Yau , David Henningsson , Luke Yelavich Subject: Re: [PATCH] ALSA: hda - Fix unused warnings when !SND_HDA_NEEDS_RESUME In-Reply-To: <1303326276-20645-1-git-send-email-mikew@google.com> References: <1303246937-11302-1-git-send-email-mikew@google.com> <1303326276-20645-1-git-send-email-mikew@google.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 20 Apr 2011 12:04:36 -0700, Mike Waychison wrote: > > When SND_HDA_NEEDS_RESUME is not defined, the compiler identifies that > the following symbols are static but not used: > > restore_shutup_pins > hda_cleanup_all_streams > > Fix warnings by adding SND_HDA_NEEDS_RESUME guards. > > Signed-off-by: Mike Waychison Applied now. Thanks! Takashi > --- > v2: > - Applies to v2.6.39-rc4. > - Dropped moving ad198x_power_eapd and ad198x_power_eapd_write at > Takashi Iwai 's request. > --- > sound/pci/hda/hda_codec.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c > index 430f41d..759ade1 100644 > --- a/sound/pci/hda/hda_codec.c > +++ b/sound/pci/hda/hda_codec.c > @@ -937,6 +937,7 @@ void snd_hda_shutup_pins(struct hda_codec *codec) > } > EXPORT_SYMBOL_HDA(snd_hda_shutup_pins); > > +#ifdef SND_HDA_NEEDS_RESUME > /* Restore the pin controls cleared previously via snd_hda_shutup_pins() */ > static void restore_shutup_pins(struct hda_codec *codec) > { > @@ -953,6 +954,7 @@ static void restore_shutup_pins(struct hda_codec *codec) > } > codec->pins_shutup = 0; > } > +#endif > > static void init_hda_cache(struct hda_cache_rec *cache, > unsigned int record_size); > @@ -1329,6 +1331,7 @@ static void purify_inactive_streams(struct hda_codec *codec) > } > } > > +#ifdef SND_HDA_NEEDS_RESUME > /* clean up all streams; called from suspend */ > static void hda_cleanup_all_streams(struct hda_codec *codec) > { > @@ -1340,6 +1343,7 @@ static void hda_cleanup_all_streams(struct hda_codec *codec) > really_cleanup_stream(codec, p); > } > } > +#endif > > /* > * amp access functions > -- > 1.7.3.1 >