From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753490Ab0DOHOG (ORCPT ); Thu, 15 Apr 2010 03:14:06 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45512 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751926Ab0DOHOC (ORCPT ); Thu, 15 Apr 2010 03:14:02 -0400 Date: Thu, 15 Apr 2010 09:14:00 +0200 Message-ID: From: Takashi Iwai To: Jens Taprogge Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: Add initial support for Thinkpad T410s HDA codec. In-Reply-To: <20100414214204.GA15425@ranger.taprogge.wh> References: <20100414214204.GA15425@ranger.taprogge.wh> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 14 Apr 2010 23:42:04 +0200, Jens Taprogge wrote: > > Dear ALSA Maintainers, > > attached please find a patch that adds support for at least the T410s > HDA codec. Most likely it will also add support for the T410 and T510 > based models. > > > The patch was derived from Ideapad support. Support for the laptop's and > docking-station output connectors as well as the docking-station microphone > connector and the laptops internal devices has been tested. Since it has been > developed without a data-sheet available, support for digital outputs and the > laptop's microphone input may well be incorrect. > > Microphone mute functionality is not included: > The microphone mute button seems to be reported through thinkpad_acpi key > 0000101b. The mute button LED seems to be wired to thinkpad_acpi led > number 15. > > Please apply. > > Signed-off-by: Jens Taprogge Thanks, applied now. Just one fix I made in addition: > @@ -2292,7 +2355,7 @@ static void cxt5066_set_mic_boost(struct hda_codec *codec) > AC_VERB_SET_AMP_GAIN_MUTE, > AC_AMP_SET_RIGHT | AC_AMP_SET_LEFT | AC_AMP_SET_OUTPUT | > cxt5066_analog_mic_boost.items[spec->mic_boost].index); > - if (spec->ideapad) { > + if (spec->ideapad | spec->thinkpad) { This should be a logical OR. Takashi