mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Oliver Neukum <oliver@neukum.org>
Cc: Dmitry Baryshkov <dbaryshkov@gmail.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: warning on device removal
Date: Fri, 05 Sep 2008 08:56:52 +0200	[thread overview]
Message-ID: <s5hr67zt70r.wl%tiwai@suse.de> (raw)
In-Reply-To: <200809041436.49083.oliver@neukum.org>

At Thu, 4 Sep 2008 14:36:48 +0200,
Oliver Neukum wrote:
> 
> Am Donnerstag 04 September 2008 14:20:22 schrieb Dmitry Baryshkov:
> > Hi,
> > 
> > I've got the following trace on one of my arm boards when removing
> > the usb masstorage device:
> > 
> > ------------[ cut here ]------------
> > WARNING: at /home/lumag/tosa-tree/arch/arm/mm/consistent.c:368 dma_free_coherent+0x34/0x248()
> > Modules linked in:
> > [<c0028fe4>] (dump_stack+0x0/0x14) from [<c003c810>] (warn_on_slowpath+0x4c/0x84)
> > [<c003c7c4>] (warn_on_slowpath+0x0/0x84) from [<c0029e54>] (dma_free_coherent+0x34/0x248)
> 
> Looks like a principal problem we have with that architecture.
> Is arm incapable of supporting buffer freeing in hard irq context
> or do we use the wrong API?

According to DMA-API.txt, dma_free_coherent() must be called with IRQ
enabled:

> void
> dma_free_coherent(struct device *dev, size_t size, void *cpu_addr,
>			   dma_addr_t dma_handle)
...
> Note that unlike their sibling allocation calls, these routines
> may only be called with IRQs enabled.


Takashi

      reply	other threads:[~2008-09-05  6:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080904122022.GA550@doriath.ww600.siemens.net>
2008-09-04 12:36 ` Oliver Neukum
2008-09-05  6:56   ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hr67zt70r.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=dbaryshkov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oliver@neukum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®