From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755863AbYG1OYe (ORCPT ); Mon, 28 Jul 2008 10:24:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751205AbYG1OYW (ORCPT ); Mon, 28 Jul 2008 10:24:22 -0400 Received: from mail.suse.de ([195.135.220.2]:43287 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753946AbYG1OYV (ORCPT ); Mon, 28 Jul 2008 10:24:21 -0400 Date: Mon, 28 Jul 2008 16:24:19 +0200 Message-ID: From: Takashi Iwai To: David Miller Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH] net/niu: Fix compile warnings User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.2 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the wrong return value from niu_ethflow_to_class(). drivers/net/niu.c: In function 'niu_get_hash_opts': drivers/net/niu.c:6481: warning: 'class' may be used uninitialized in this function drivers/net/niu.c: In function 'niu_set_hash_opts': drivers/net/niu.c:6501: warning: 'class' may be used uninitialized in this function Signed-off-by: Takashi Iwai --- diff --git a/drivers/net/niu.c b/drivers/net/niu.c index 8ee7d7b..e4765b7 100644 --- a/drivers/net/niu.c +++ b/drivers/net/niu.c @@ -6417,7 +6417,7 @@ static int niu_ethflow_to_class(int flow_type, u64 *class) *class = CLASS_CODE_SCTP_IPV6; break; default: - return -1; + return 0; } return 1;