From: Takashi Iwai <tiwai@suse.de>
To: David Brownell <david-b@pacbell.net>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2.6.21-rc4-git] fix SND_SOC Kconfig
Date: Wed, 21 Mar 2007 12:27:45 +0100 [thread overview]
Message-ID: <s5hr6ribzv2.wl%tiwai@suse.de> (raw)
In-Reply-To: <200703201349.52156.david-b@pacbell.net>
At Tue, 20 Mar 2007 13:49:51 -0700,
David Brownell wrote:
>
> The new ALSA "SOC" support has bogus Kconfig ... it should
> not be presenting anything AT91-related except on AT91,
> or anything PXA-related except on PXA. Right now, x86
> sees both of those menus, as do all other platforms.
>
> This patch removes needless Kconfig layering, and the
> related inappropriate choice presentation.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Thanks, I applied it to ALSA tree now.
Takashi
>
> Index: g26/sound/soc/Kconfig
> ===================================================================
> --- g26.orig/sound/soc/Kconfig 2007-03-18 14:11:36.000000000 -0700
> +++ g26/sound/soc/Kconfig 2007-03-20 13:33:06.000000000 -0700
> @@ -22,11 +22,8 @@ config SND_SOC
> will be called snd-soc-core.
>
> # All the supported Soc's
> -menu "SoC Platforms"
> -depends on SND_SOC
> source "sound/soc/at91/Kconfig"
> source "sound/soc/pxa/Kconfig"
> -endmenu
>
> # Supported codecs
> source "sound/soc/codecs/Kconfig"
> Index: g26/sound/soc/at91/Kconfig
> ===================================================================
> --- g26.orig/sound/soc/at91/Kconfig 2007-03-18 14:11:36.000000000 -0700
> +++ g26/sound/soc/at91/Kconfig 2007-03-20 13:31:52.000000000 -0700
> @@ -1,5 +1,3 @@
> -menu "SoC Audio for the Atmel AT91"
> -
> config SND_AT91_SOC
> tristate "SoC Audio for the Atmel AT91 System-on-Chip"
> depends on ARCH_AT91 && SND_SOC
> @@ -27,5 +25,3 @@ config SND_AT91_SOC_ETI_SLAVE
> help
> Say Y if you want to run with the AT91 SSC generating the BCLK
> and LRC signals on Endrelia boards.
> -
> -endmenu
> Index: g26/sound/soc/pxa/Kconfig
> ===================================================================
> --- g26.orig/sound/soc/pxa/Kconfig 2007-03-18 14:11:36.000000000 -0700
> +++ g26/sound/soc/pxa/Kconfig 2007-03-20 13:31:57.000000000 -0700
> @@ -1,5 +1,3 @@
> -menu "SoC Audio for the Intel PXA2xx"
> -
> config SND_PXA2XX_SOC
> tristate "SoC Audio for the Intel PXA2xx chip"
> depends on ARCH_PXA && SND_SOC
> @@ -55,5 +53,3 @@ config SND_PXA2XX_SOC_TOSA
> help
> Say Y if you want to add support for SoC audio on Sharp
> Zaurus SL-C6000x models (Tosa).
> -
> -endmenu
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
prev parent reply other threads:[~2007-03-21 11:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 20:49 David Brownell
2007-03-21 11:27 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hr6ribzv2.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome