mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Werner Sembach <wse@tuxedocomputers.com>
Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
Date: Tue, 02 Mar 2021 15:06:54 +0100	[thread overview]
Message-ID: <s5hsg5dfy4h.wl-tiwai@suse.de> (raw)
In-Reply-To: <c7a394b1-edd3-a692-0981-45086da82aac@tuxedocomputers.com>

On Tue, 02 Mar 2021 12:19:03 +0100,
Werner Sembach wrote:
> 
> From: Eckhart Mohr <e.mohr@tuxedocomputers.com>
> 
> ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
> 
> This applies a SND_PCI_QUIRK(...) to the Clevo NH55RZQ barebone. This
> fixes the issue of the device not recognizing a pluged in microphone.
> 
> The device has both, a microphone only jack, and a speaker + microphone
> combo jack. The combo jack already works. The microphone-only jack does
> not recognize when a device is pluged in without this patch.
> 
> Signed-off-by: Eckhart Mohr <e.mohr@tuxedocomputers.com>
> Co-developed-by: Werner Sembach <wse@tuxedocomputers.com>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> Hi,
> this is my first ever submitted kernel patch, feel free to criticise me if I made an error or missed a best practise bullet point.

The patch isn't cleanly applicable.  Could you try to submit via
git-send-email instead?

> Also: I'm unsure if this would fit the requirements for stable@vger.kernel.org and/or trivial@kernel.org, but I think not (correct me if I'm wrong).

Cc to stable is worthwhile.  You can simply add
  Cc: <stable@vger.kernel.org>

around your signed-off-by lines in the patch.


thanks,

Takashi

  reply	other threads:[~2021-03-02 16:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-02 11:19 Werner Sembach
2021-03-02 14:06 ` Takashi Iwai [this message]
2021-03-02 16:51   ` Werner Sembach
2021-03-02 16:25 Werner Sembach
2021-03-02 17:33 ` Takashi Iwai
2021-03-02 18:10   ` Werner Sembach
2021-03-02 18:00 Werner Sembach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hsg5dfy4h.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=wse@tuxedocomputers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®