From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=UfG/=NY=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 35EF4C43441
	for <linux-kernel@archiver.kernel.org>; Tue, 13 Nov 2018 17:32:35 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 0009F2086B
	for <linux-kernel@archiver.kernel.org>; Tue, 13 Nov 2018 17:32:34 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0009F2086B
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1731786AbeKNDbh (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 13 Nov 2018 22:31:37 -0500
Received: from mx2.suse.de ([195.135.220.15]:55918 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1730995AbeKNDbh (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 13 Nov 2018 22:31:37 -0500
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay1.suse.de (unknown [195.135.220.254])
        by mx1.suse.de (Postfix) with ESMTP id ACFF9ABE7;
        Tue, 13 Nov 2018 17:32:31 +0000 (UTC)
Date:   Tue, 13 Nov 2018 18:32:30 +0100
Message-ID: <s5hsh04c28h.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Ayman Bagabas" <ayman.bagabas@gmail.com>
Cc:     <alsa-devel@alsa-project.org>, "Hui Wang" <hui.wang@canonical.com>,
        "Andy Shevchenko" <andy@infradead.org>,
        "Darren Hart" <dvhart@infradead.org>,
        "Jaroslav Kysela" <perex@perex.cz>,
        "Kailang Yang" <kailang@realtek.com>,
        <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v5 3/3] ALSA: hda: add support for Huawei WMI micmute LED
In-Reply-To: <20181111190250.6055-4-ayman.bagabas@gmail.com>
References: <20181111190250.6055-1-ayman.bagabas@gmail.com>
        <20181111190250.6055-4-ayman.bagabas@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 11 Nov 2018 20:02:45 +0100,
Ayman Bagabas wrote:
> 
> Some of Huawei laptops come with a LED in the micmute key. This patch
> enables and disable this LED accordingly.

disable what?

> This enables micmute LED for:
> 1. Matebook X (19e5:3200), (19e5:3201)
> 2. Matebook X Pro (19e5:3204)
> 
> Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>

The code changes are mostly OK.  Just a minor nitpicking:

> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5374,6 +5374,9 @@ static void alc_fixup_thinkpad_acpi(struct hda_codec *codec,
>  /* for alc295_fixup_hp_top_speakers */
>  #include "hp_x360_helper.c"
>  
> +/* for alc_fixup_huawei_micmute_led */

This should be alc_fixup_huawei_wmi */

With that fix,
  Reviewed-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi