From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754691AbcGEGhq (ORCPT ); Tue, 5 Jul 2016 02:37:46 -0400 Received: from mx2.suse.de ([195.135.220.15]:50358 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752965AbcGEGhp (ORCPT ); Tue, 5 Jul 2016 02:37:45 -0400 Date: Tue, 05 Jul 2016 08:37:43 +0200 Message-ID: From: Takashi Iwai To: "Arnd Bergmann" Cc: "Jaroslav Kysela" , , Subject: Re: [PATCH] ALSA: ppc/awacs: shut up maybe-uninitialized warning In-Reply-To: <20160704150759.2909708-1-arnd@arndb.de> References: <20160704150759.2909708-1-arnd@arndb.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 04 Jul 2016 17:07:45 +0200, Arnd Bergmann wrote: > > The awacs sound driver produces a false-positive warning in ppc64_defconfig: > > sound/ppc/awacs.c: In function 'snd_pmac_awacs_init': > include/sound/control.h:219:9: warning: 'master_vol' may be used uninitialized in this function [-Wmaybe-uninitialized] > > I haven't come up with a good way to rewrite the code to avoid the > warning, so here is a bad one: I initialize the variable before > the conditionall initialization so gcc no longer has to worry about > it. > > Signed-off-by: Arnd Bergmann Applied, thanks. Takashi