Re: [PATCH] sound: pci: azt3328.c: Cleaning up function that are not used anywhere

[Takashi Iwai <tiwai@suse.de>]

At Wed,  3 Dec 2014 00:08:09 +0100,
Rickard Strandqvist wrote:
> 
> Remove function snd_azf3328_codec_outl() that is not used anywhere.

This is a small inliner and no problem to keep it.  Removing it breaks
the code balance, and one would have to re-add it if 32bit register
address is needed in the future patch.


thanks,

Takashi

> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
>  sound/pci/azt3328.c |    9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/sound/pci/azt3328.c b/sound/pci/azt3328.c
> index 5a69e26..82da7b9 100644
> --- a/sound/pci/azt3328.c
> +++ b/sound/pci/azt3328.c
> @@ -379,15 +379,6 @@ snd_azf3328_codec_inw(const struct snd_azf3328_codec_data *codec, unsigned reg)
>  }
>  
>  static inline void
> -snd_azf3328_codec_outl(const struct snd_azf3328_codec_data *codec,
> -		       unsigned reg,
> -		       u32 value
> -)
> -{
> -	outl(value, codec->io_base + reg);
> -}
> -
> -static inline void
>  snd_azf3328_codec_outl_multi(const struct snd_azf3328_codec_data *codec,
>  			     unsigned reg, const void *buffer, int count
>  )
> -- 
> 1.7.10.4
>