From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753361AbaIVIVX (ORCPT ); Mon, 22 Sep 2014 04:21:23 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57782 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128AbaIVIVW (ORCPT ); Mon, 22 Sep 2014 04:21:22 -0400 Date: Mon, 22 Sep 2014 10:21:19 +0200 Message-ID: From: Takashi Iwai To: Sudip Mukherjee Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] sound: pci: ctxfi: added reference of snd_card In-Reply-To: <20140922081541.GC4870@sudip-PC> References: <1411315421-24138-1-git-send-email-sudipm.mukherjee@gmail.com> <20140922081541.GC4870@sudip-PC> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 22 Sep 2014 13:45:41 +0530, Sudip Mukherjee wrote: > > On Mon, Sep 22, 2014 at 09:04:53AM +0200, Takashi Iwai wrote: > > At Sun, 21 Sep 2014 21:33:37 +0530, > > Sudip Mukherjee wrote: > > > > > > added and initialized a pointer of snd_card in the struct hw to get a reference of > > > the card in other functions > > > > You need to explain why this change is needed. The above text shows > > what it'd do, but it doesn't give any explanation to convince why this > > patch must be merged in. In this case, it's a preliminary patch for > > the changes to convert to dev_*() later. It's the most important bit, > > so don't forget it. > > > then do i mention in the commit that it is the preliminary patch for the later changes to dev_* ? If the purpose of this patch is so, just write what it'll be used for. > i was thinking that we can get a reference of the card from other functions which are using struct hw > is a reason by itself. If the purpose of this patch is rather broader, just write what it'll be used for. Do you see what was missing? Takashi