From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753661Ab3EMNzH (ORCPT ); Mon, 13 May 2013 09:55:07 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47481 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751230Ab3EMNzG (ORCPT ); Mon, 13 May 2013 09:55:06 -0400 Date: Mon, 13 May 2013 15:55:01 +0200 Message-ID: From: Takashi Iwai To: Paul Bolle Cc: Jaroslav Kysela , Andrew Morton , Ralf Baechle , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: Fix make allmodconfig on MIPS correctly In-Reply-To: <1368361879.1350.13.camel@x61.thuisdomein> References: <1368361879.1350.13.camel@x61.thuisdomein> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 12 May 2013 14:31:19 +0200, Paul Bolle wrote: > > Commit d4702b189c ("sound: Fix make allmodconfig on MIPS") added a > (negative) dependency on ISA_DMA_SUPPORT_BROKEN. Since that Kconfig > symbol doesn't exist, this dependency will always evaluate to true. > Apparently GENERIC_ISA_DMA_SUPPORT_BROKEN was meant to be used here. > > Signed-off-by: Paul Bolle Thanks, applied. Takashi > --- > Tested only with "git grep". > > sound/oss/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/oss/Kconfig b/sound/oss/Kconfig > index 51c4ba9..1a96402 100644 > --- a/sound/oss/Kconfig > +++ b/sound/oss/Kconfig > @@ -250,7 +250,7 @@ config MSND_FIFOSIZE > menuconfig SOUND_OSS > tristate "OSS sound modules" > depends on ISA_DMA_API && VIRT_TO_BUS > - depends on !ISA_DMA_SUPPORT_BROKEN > + depends on !GENERIC_ISA_DMA_SUPPORT_BROKEN > help > OSS is the Open Sound System suite of sound card drivers. They make > sound programming easier since they provide a common API. Say Y or > -- > 1.7.11.7 >