From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751251Ab2DRFtv (ORCPT ); Wed, 18 Apr 2012 01:49:51 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33308 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750769Ab2DRFtu (ORCPT ); Wed, 18 Apr 2012 01:49:50 -0400 Date: Wed, 18 Apr 2012 07:49:47 +0200 Message-ID: From: Takashi Iwai To: Josh Boyer Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-team@fedoraproject.org, kevin@scrye.com, cwickert@fedoraproject.org Subject: Re: Thinkpad hda regression in 3.3 In-Reply-To: <20120418002336.GK19507@zod.bos.redhat.com> References: <20120413124306.GC25425@zod.bos.redhat.com> <20120413180814.GG25425@zod.bos.redhat.com> <20120418002336.GK19507@zod.bos.redhat.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 17 Apr 2012 20:23:36 -0400, Josh Boyer wrote: > > On Fri, Apr 13, 2012 at 02:08:14PM -0400, Josh Boyer wrote: > > On Fri, Apr 13, 2012 at 06:07:47PM +0200, Takashi Iwai wrote: > > > At Fri, 13 Apr 2012 15:07:07 +0200, > > > Takashi Iwai wrote: > > > (snip) > > > > If the above seem work (again, make sure that you adjust the mixer > > > > mutes and levels), I'll make kernel patches to add these fixups > > > > statically in the driver so that it works without extra patching. > > > > > > Looking through alsa-info.sh outputs from various ThinkPad models I've > > > gathered, it seems that we can use the same pin setups for all. > > > > We had a user try the alsa-tp-dock patch on an X201 and it didn't seem > > to work for them. See bug > > https://bugzilla.redhat.com/show_bug.cgi?id=806217 > > > > Perhaps the [codec] section isn't set properly for their configuration? > > The alsa-info for their machine is in comment #9 of the bug. > > > > > Below is a test patch for 3.3 kernel. (Note that it'd give a merge > > > conflict for 3.4 kernel.) > > > > OK, I'll do a scratch build with this and get people to test. > > I built your patch in a scratch kernel and have at least one user with a > t510 laptop report success. Christoph reported the mixers showing up, > but it wasn't clear to me if his sound actually worked on the x201. > I've CC'd both users (Kevin t510, Christoph x201 in a dock). Good. Should I wait for a copule of days for the test results before merging the patch, or go for now? thanks, Takashi