From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1753002AbYHPJEB@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753002AbYHPJEB (ORCPT <rfc822;w@1wt.eu>);
	Sat, 16 Aug 2008 05:04:01 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751271AbYHPJDx
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sat, 16 Aug 2008 05:03:53 -0400
Received: from mx2.suse.de ([195.135.220.15]:37595 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751098AbYHPJDw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 16 Aug 2008 05:03:52 -0400
Date: Sat, 16 Aug 2008 11:03:51 +0200
Message-ID: <s5hskt5nxfs.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Jeff Mahoney <jeffm@suse.com>, Andrew Morton <akpm@linux-foundation.org>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: Fix creation of include2/asm symlink
In-Reply-To: <20080815194954.GA18377@uranus.ravnborg.org>
References: <s5hod3u5r3d.wl%tiwai@suse.de>
	<20080815194954.GA18377@uranus.ravnborg.org>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.2
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Fri, 15 Aug 2008 21:49:54 +0200,
Sam Ravnborg wrote:
> 
> On Fri, Aug 15, 2008 at 03:45:58PM +0200, Takashi Iwai wrote:
> > The directory include2/asm can point wrongly to a non-existing
> > directory on architectures that have moved include/asm under arch/*.
> > 
> > This patch fixes it by checking firstly whether arch/*/include/asm is
> > available.
> 
> Hi Takashi.
> 
> I understand why you try to avoid include2/asm as it is not pretty.
> And I had a similar patch once - but I dropped it as the symlink do
> not harm and it will anyway be gone when the remaining architectures
> has shifted to use arch/$ARCH/include/...
> 
> So I will not apply it.

Hm, OK.  Originally I fixed it because our build system has a sanity
check against bogus symlinks and refused to package the latest kernel.
If you don't want to put it in, we can keep it locally, of course.
But, a bogus symlink is definitely not pretty...


thanks,

Takashi