From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161230AbXAHLVq (ORCPT ); Mon, 8 Jan 2007 06:21:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751470AbXAHLVq (ORCPT ); Mon, 8 Jan 2007 06:21:46 -0500 Received: from mx1.suse.de ([195.135.220.2]:41237 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751466AbXAHLVp (ORCPT ); Mon, 8 Jan 2007 06:21:45 -0500 Date: Mon, 08 Jan 2007 12:21:44 +0100 Message-ID: From: Takashi Iwai To: Mariusz Kozlowski Cc: Johannes Berg , linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [Alsa-devel] [PATCH] sound: aoa of_node_put and kfree cleanup In-Reply-To: <200701021350.57816.m.kozlowski@tuxland.pl> References: <200701021350.57816.m.kozlowski@tuxland.pl> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27) (fiddleheads) (+CVS-20060704) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 2 Jan 2007 13:50:57 +0100, Mariusz Kozlowski wrote: > > Hello, > > This patch removes redundant argument checks for of_node_put() and kfree(). > > Signed-off-by: Mariusz Kozlowski > > sound/aoa/fabrics/snd-aoa-fabric-layout.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Merged to ALSA tree now. Thanks. Takashi > > diff -upr linux-2.6.20-rc2-mm1-a/sound/aoa/fabrics/snd-aoa-fabric-layout.c linux-2.6.20-rc2-mm1-b/sound/aoa/fabrics/snd-aoa-fabric-layout.c > --- linux-2.6.20-rc2-mm1-a/sound/aoa/fabrics/snd-aoa-fabric-layout.c 2006-12-28 12:57:54.000000000 +0100 > +++ linux-2.6.20-rc2-mm1-b/sound/aoa/fabrics/snd-aoa-fabric-layout.c 2007-01-02 01:50:26.000000000 +0100 > @@ -1034,9 +1034,9 @@ static int aoa_fabric_layout_probe(struc > list_del(&ldev->list); > layouts_list_items--; > outnodev: > - if (sound) of_node_put(sound); > + of_node_put(sound); > layout_device = NULL; > - if (ldev) kfree(ldev); > + kfree(ldev); > return -ENODEV; > } > > > > -- > Regards, > > Mariusz Kozlowski > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/alsa-devel >