From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1751641AbWCXLJN@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751641AbWCXLJN (ORCPT <rfc822;willy@w.ods.org>);
	Fri, 24 Mar 2006 06:09:13 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751639AbWCXLJN
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 24 Mar 2006 06:09:13 -0500
Received: from mx1.suse.de ([195.135.220.2]:23198 "EHLO mx1.suse.de")
	by vger.kernel.org with ESMTP id S1751497AbWCXLJM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 24 Mar 2006 06:09:12 -0500
Date: Fri, 24 Mar 2006 12:09:11 +0100
Message-ID: <s5hslp8nlpk.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Rene Herman <rene.herman@keyaccess.nl>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
       ALSA devel <alsa-devel@alsa-project.org>,
       Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [ALSA] ISA drivers bailing on first IS_ERR
In-Reply-To: <4423848E.9030805@keyaccess.nl>
References: <4423848E.9030805@keyaccess.nl>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta25)
 (eggplant) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

At Fri, 24 Mar 2006 06:33:02 +0100,
Rene Herman wrote:
> 
> Hi Takashi.
> 
> If as per the previous message an error return from the probe() method
> should make platform_driver_register_simple() return IS_ERR, then the
> SNDRV_CARDS loop should continue with the next one, instead of bailing.
> 
> If the bus_add_device() patch and the attached is applied, the pre
> platform_driver behaviour of not loading on not finding any devices (and
> printing a message to that effect) is restored. Without, the printk is
> dead code.
> 
> This has been generated against 2.6.16 + the earlier !enable[i] patch.

These looks OK to me.  Could you regenerate patches against the latest
git (or ALSA CVS) ?

Or, it might be better against to mm tree, since pnp registrations
will be modified there, too.  They should go also to mainstream
together.


Nevertheless, the patches (this and the previous one) are good to go
to stable tree, too.


thanks,

Takashi