From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F10B2C433EF for ; Thu, 7 Apr 2022 06:02:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234958AbiDGGEO (ORCPT ); Thu, 7 Apr 2022 02:04:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230055AbiDGGEL (ORCPT ); Thu, 7 Apr 2022 02:04:11 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C7D717586E for ; Wed, 6 Apr 2022 23:02:12 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 29BA221117; Thu, 7 Apr 2022 06:02:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1649311331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zcVA2leKEHZCBy0L6O+DAKg05GvJhbtAx6yj2EYofvk=; b=vZ2m/aITGXDAq6n8nhnsUrvPRMPIkKnWD/KRTTGFB0nr+ykHFGw/AEtWdF/ElB9rJTby5g zNbcBPB8Y50/7gHSfWJ/iEOpR6naCLf3Oe41SYm5L+Xa4ekwfdom+aUoi51z0/gBcsjLOt y8X0HtBS9VZ9cc/hc78ohGsHPsQxwd8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1649311331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zcVA2leKEHZCBy0L6O+DAKg05GvJhbtAx6yj2EYofvk=; b=6z+z7H4qA0BPXVQG32Ue9gbbgIcmW0u3QrAwQSja86P/ki0wj6NwbYCk//jpel7RvfXrjt INS2E3TFJ5EGqoBg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 1F97FA3B82; Thu, 7 Apr 2022 06:02:10 +0000 (UTC) Date: Thu, 07 Apr 2022 08:02:10 +0200 Message-ID: From: Takashi Iwai To: Takashi Sakamoto Cc: clemens@ladisch.de, alsa-devel@alsa-project.org, linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/3] firewire: assist unit driver to compute packet time stamp In-Reply-To: References: <20220405072221.226217-1-o-takashi@sakamocchi.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 07 Apr 2022 02:10:21 +0200, Takashi Sakamoto wrote: > > On Tue, Apr 05, 2022 at 06:23:35PM +0200, Takashi Iwai wrote: > > On Tue, 05 Apr 2022 09:22:18 +0200, > > Takashi Sakamoto wrote: > > > > > > Hi, > > > > > > Current implementation of Linux FireWire subsystem doesn't allow unit > > > driver to operate content of packet in IR context according to > > > time stamp. Additionally it doesn't allow unit driver to read current value > > > of CYCLE_TIME register in OHCI 1394 controller. It brings disadvantages to > > > drivers in Linux sound subsystem in regards of handling time for sampled > > > data such as PCM frames and MIDI messages. > > > > > > This rerolled patchset is first step to improve the situation. > > > > > > Changes in v3: > > > * Rebase v2 patchset to v5.18-rc1 > > > Changes in v2: > > > * Rebase v1 patchset to v5.16 release > > > * https://lore.kernel.org/lkml/20220212022131.199855-1-o-takashi@sakamocchi.jp/ > > > V1: > > > * https://lore.kernel.org/lkml/20211202113457.24011-1-o-takashi@sakamocchi.jp/ > > > > > > Hector Martin (1): > > > firewire: Add dummy read_csr/write_csr functions > > > > > > Takashi Sakamoto (2): > > > firewire: add kernel API to access CYCLE_TIME register > > > firewire: add kernel API to access packet structure in request > > > structure for AR context > > > > Thanks, applied all three patches now to for-next branch. > > Although thanks for your applying them into your tree, I apologize to > trouble you if you overlook that the included changes is just for Linux > FireWire subsystem. It's my fault to send them only to Linux sound > subsystem, but the changes are required to my work in sound drivers... > > If you are willing to include patches to Linux FireWire subsystem for > your pull-request to Linus, I can prepare respined patches for it since > I have the list of patches posted to LKML as bug fixes for Linux FireWire > subsystem. > > I need any help to solve current situation of Linux FireWire subsystem > that bug fixes and new changes are hardly merged. Of course, IEEE 1394 bus > is already outdated and legacy, but I know that some users still work > with it. If your path is available for it, it's the easiest and the most > convenient way for upstreaming, I think. Ah OK, it's fine for me in either way. I can keep up those changes in my tree, or go through others. I leave the decision Firewire subsystem people. Just let me know. thanks, Takashi