mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Tong Zhang <ztong0001@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Romain Perier <romain.perier@gmail.com>,
	Allen Pais <allen.lkml@gmail.com>,
	Leon Romanovsky <leon@kernel.org>,
	Jasmin Fazlic <superfassl@gmail.com>,
	Mark Brown <broonie@kernel.org>, Joe Perches <joe@perches.com>,
	Tom Rix <trix@redhat.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] ALSA: hdsp and hdspm, don't disable device if not enabled
Date: Sun, 21 Mar 2021 09:16:14 +0100	[thread overview]
Message-ID: <s5htup4exbl.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210320222337.243368-1-ztong0001@gmail.com>

On Sat, 20 Mar 2021 23:23:33 +0100,
Tong Zhang wrote:
> 
> This series fixes issues in hdsp and hdspm. The drivers in question want
> to disable a device that is not enabled on error path.
> 
> v2: add fix to rme9652
> 
> Tong Zhang (3):
>   ALSA: hdsp: don't disable if not enabled
>   ALSA: hdspm: don't disable if not enabled
>   ALSA: rme9652: don't disable if not enabled

Thanks for the patches.

IMO, a safer way for this is to add pci_is_enabled() check in *_free()
functions around the call of pci_disable_device().  The point is that
*_free() is the sole destructor function that manages all stuff, hence
it's better to do all there.  And, of course, it'll be less changes.

Care to resend v3 patches with that?


thanks,

Takashi

  parent reply	other threads:[~2021-03-21  8:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-20 22:23 Tong Zhang
2021-03-20 22:23 ` [PATCH v2 1/3] ALSA: hdsp: don't disable " Tong Zhang
2021-03-20 22:23 ` [PATCH v2 2/3] ALSA: hdspm: " Tong Zhang
2021-03-20 22:23 ` [PATCH v2 3/3] ALSA: rme9652: " Tong Zhang
2021-03-21  8:16 ` Takashi Iwai [this message]
2021-03-21 15:38   ` [PATCH v3 0/3] ALSA: rme9652 don't disable device " Tong Zhang
2021-03-22 11:21     ` Takashi Iwai
2021-03-21 15:38   ` [PATCH v3 1/3] ALSA: hdsp: don't disable " Tong Zhang
2021-03-21 15:38   ` [PATCH v3 2/3] ALSA: hdspm: " Tong Zhang
2021-03-21 15:38   ` [PATCH v3 3/3] ALSA: rme9652: " Tong Zhang
2021-03-21 15:40   ` [PATCH v2 0/3] ALSA: hdsp and hdspm, don't disable device " Tong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5htup4exbl.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=allen.lkml@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=gustavoars@kernel.org \
    --cc=joe@perches.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=romain.perier@gmail.com \
    --cc=superfassl@gmail.com \
    --cc=tiwai@suse.com \
    --cc=trix@redhat.com \
    --cc=ztong0001@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome