From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72AB6C388F9 for ; Sat, 21 Nov 2020 08:26:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B34F22240 for ; Sat, 21 Nov 2020 08:26:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727297AbgKUI0x (ORCPT ); Sat, 21 Nov 2020 03:26:53 -0500 Received: from mx2.suse.de ([195.135.220.15]:35562 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727082AbgKUI0x (ORCPT ); Sat, 21 Nov 2020 03:26:53 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 46297ABE4; Sat, 21 Nov 2020 08:26:51 +0000 (UTC) Date: Sat, 21 Nov 2020 09:26:51 +0100 Message-ID: From: Takashi Iwai To: Christophe JAILLET Cc: perex@perex.cz, tiwai@suse.com, dan.carpenter@oracle.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ALSA: emu10k1: Use dma_set_mask_and_coherent to simplify code In-Reply-To: <20201121081632.1330159-1-christophe.jaillet@wanadoo.fr> References: <20201121081632.1330159-1-christophe.jaillet@wanadoo.fr> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 21 Nov 2020 09:16:32 +0100, Christophe JAILLET wrote: > > 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by > an equivalent 'dma_set_mask_and_coherent()' which is much less verbose. It's a good cleanup, but ... > With at it replace the 'card->dev' parameter passed to a 'dev_err()' call > by an equivalent '&pci->dev' which is more consistent with the test just > one line above. ... this will make it inconsistent with other error message lines in the same function, OTOH. So I don't think this part necessary to be changed. thanks, Takashi