From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C43AC433DF for ; Sat, 11 Jul 2020 09:04:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D63832077D for ; Sat, 11 Jul 2020 09:04:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728214AbgGKJEP (ORCPT ); Sat, 11 Jul 2020 05:04:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:53974 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728049AbgGKJEO (ORCPT ); Sat, 11 Jul 2020 05:04:14 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0C83DAAC7; Sat, 11 Jul 2020 09:04:14 +0000 (UTC) Date: Sat, 11 Jul 2020 11:04:12 +0200 Message-ID: From: Takashi Iwai To: Navid Emamdoost Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, emamd001@umn.edu, kjlu@umn.edu, smccaman@umn.edu Subject: Re: [PATCH] ALSA: trident: Fix a memory leak in snd_trident_create In-Reply-To: <20200711070835.4855-1-navid.emamdoost@gmail.com> References: <20200711070835.4855-1-navid.emamdoost@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 11 Jul 2020 09:08:30 +0200, Navid Emamdoost wrote: > > In the implementation of snd_trident_create(), the allocated trident is > leaked if snd_trident_mixer() fails. Release via snd_trident_free(). No, this patch would result in double-free. The manual release of trident object isn't needed once after it gets added via snd_device_new(). Then it'll be automatically released at the error path (via snd_trident_dev_free()). thanks, Takashi > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Navid Emamdoost > --- > sound/pci/trident/trident_main.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/sound/pci/trident/trident_main.c b/sound/pci/trident/trident_main.c > index 6e50376163a2..e98c692f6aa9 100644 > --- a/sound/pci/trident/trident_main.c > +++ b/sound/pci/trident/trident_main.c > @@ -3582,8 +3582,11 @@ int snd_trident_create(struct snd_card *card, > return err; > } > > - if ((err = snd_trident_mixer(trident, pcm_spdif_device)) < 0) > + err = snd_trident_mixer(trident, pcm_spdif_device); > + if (err < 0) { > + snd_trident_free(trident); > return err; > + } > > /* initialise synth voices */ > for (i = 0; i < 64; i++) { > -- > 2.17.1 >