From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FFA8C433DF for ; Wed, 8 Jul 2020 07:13:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85A97206DF for ; Wed, 8 Jul 2020 07:13:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730031AbgGHHNM (ORCPT ); Wed, 8 Jul 2020 03:13:12 -0400 Received: from mx2.suse.de ([195.135.220.15]:50618 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729836AbgGHHNM (ORCPT ); Wed, 8 Jul 2020 03:13:12 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 84907ACA0; Wed, 8 Jul 2020 07:13:11 +0000 (UTC) Date: Wed, 08 Jul 2020 09:13:10 +0200 Message-ID: From: Takashi Iwai To: "Gustavo A. R. Silva" Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ludovic Desroches , Nicolas Ferre Subject: Re: [PATCH] ALSA: Use fallthrough pseudo-keyword In-Reply-To: <20200707172847.GA27659@embeddedor> References: <20200707172847.GA27659@embeddedor> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 07 Jul 2020 19:28:47 +0200, Gustavo A. R. Silva wrote: > --- a/sound/isa/msnd/msnd_pinnacle_mixer.c > +++ b/sound/isa/msnd/msnd_pinnacle_mixer.c > @@ -219,8 +219,7 @@ static int snd_msndmix_set(struct snd_msnd *dev, int d, int left, int right) > case MSND_MIXER_VOLUME: /* master volume */ > writew(wLeft, dev->SMA + SMA_wCurrMastVolLeft); > writew(wRight, dev->SMA + SMA_wCurrMastVolRight); > - /* fall through */ > - > + fallthrough; > case MSND_MIXER_AUX: /* aux pot control */ > /* scaled by master volume */ > /* fall through */ Any reason to leave this? thanks, Takashi